Bug 188916 - [CoordGraphics] Move inline methods on CoordinatedGraphicsLayer out-of-line
Summary: [CoordGraphics] Move inline methods on CoordinatedGraphicsLayer out-of-line
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-23 23:22 PDT by Zan Dobersek
Modified: 2018-08-24 02:14 PDT (History)
9 users (show)

See Also:


Attachments
Patch (3.69 KB, patch)
2018-08-23 23:25 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch for landing (4.53 KB, patch)
2018-08-24 00:55 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-08-23 23:22:54 PDT
Should address this:

> ERROR:
> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.
> h:114:  Inline functions should not be in classes annotated with
> WEBCORE_EXPORT. Remove the macro from the class and apply it to each
> appropriate method, or move the inline function definition out-of-line. 
> [build/webcore_export] [4]
> Total errors found: 1 in 9 files
Comment 1 Zan Dobersek 2018-08-23 23:25:46 PDT
Created attachment 347995 [details]
Patch
Comment 2 Zan Dobersek 2018-08-24 00:55:16 PDT
Created attachment 347997 [details]
Patch for landing

Also out-lines the usesContentLayer() method.
Comment 3 Zan Dobersek 2018-08-24 02:13:49 PDT
Comment on attachment 347997 [details]
Patch for landing

Clearing flags on attachment: 347997

Committed r235314: <https://trac.webkit.org/changeset/235314>
Comment 4 Zan Dobersek 2018-08-24 02:13:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-08-24 02:14:16 PDT
<rdar://problem/43677220>