Bug 188881 - [CoordGraphics] Remove the remaining CoordinatedGraphicsLayerState cruft
Summary: [CoordGraphics] Remove the remaining CoordinatedGraphicsLayerState cruft
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks: 187385
  Show dependency tree / graph
 
Reported: 2018-08-23 00:21 PDT by Zan Dobersek
Modified: 2018-08-23 23:23 PDT (History)
5 users (show)

See Also:

Attachments
Patch (37.05 KB, patch)
2018-08-23 00:33 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (37.08 KB, patch)
2018-08-23 00:39 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-08-23 00:21:49 PDT 
[CoordGraphics] Remove the remaining CoordinatedGraphicsLayerState cruft
Comment 1 Zan Dobersek 2018-08-23 00:33:11 PDT 
Created attachment 347915 [details]
Patch
Comment 2 EWS Watchlist 2018-08-23 00:34:52 PDT 
Attachment 347915 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:114:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zan Dobersek 2018-08-23 00:39:09 PDT 
Created attachment 347916 [details]
Patch
Comment 4 EWS Watchlist 2018-08-23 00:40:44 PDT 
Attachment 347916 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:114:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Zan Dobersek 2018-08-23 05:34:39 PDT 
Comment on attachment 347916 [details]
Patch

Clearing flags on attachment: 347916

Committed r235221: <https://trac.webkit.org/changeset/235221>
Comment 6 Zan Dobersek 2018-08-23 05:34:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-08-23 05:35:23 PDT 
<rdar://problem/43640432>
Comment 8 Michael Catanzaro 2018-08-23 07:52:34 PDT 
I think you need to fix this:

(In reply to Build Bot from comment #4) 
> ERROR:
> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.
> h:114:  Inline functions should not be in classes annotated with
> WEBCORE_EXPORT. Remove the macro from the class and apply it to each
> appropriate method, or move the inline function definition out-of-line. 
> [build/webcore_export] [4]
> Total errors found: 1 in 9 files
Comment 9 Zan Dobersek 2018-08-23 23:23:34 PDT 
(In reply to Michael Catanzaro from comment #8)
> I think you need to fix this:
> 
> (In reply to Build Bot from comment #4) 
> > ERROR:
> > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.
> > h:114:  Inline functions should not be in classes annotated with
> > WEBCORE_EXPORT. Remove the macro from the class and apply it to each
> > appropriate method, or move the inline function definition out-of-line. 
> > [build/webcore_export] [4]
> > Total errors found: 1 in 9 files

Bug #188916.