RESOLVED FIXED 188773
[WHLSL] Allow native types to have type arguments (like "vector<float, 4>") 
https://bugs.webkit.org/show_bug.cgi?id=188773
Summary [WHLSL] Allow native types to have type arguments (like "vector<float, 4>")
Myles C. Maxfield
Reported 2018-08-20 19:39:12 PDT
[WHLSL] Allow native types to have type arguments (like "vector<float, 4>")
Attachments
WIP (37.49 KB, patch)
2018-08-20 19:39 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (54.25 KB, patch)
2018-08-21 13:03 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (65.44 KB, patch)
2018-08-21 15:58 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (75.23 KB, patch)
2018-08-21 19:26 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (72.82 KB, patch)
2018-08-21 19:39 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Needs tests (72.76 KB, patch)
2018-08-22 13:32 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Setting .type in Checker will break TypeDefResolver (78.11 KB, patch)
2018-08-22 14:21 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (78.77 KB, patch)
2018-08-22 15:48 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2018-08-20 19:39:46 PDT
Created attachment 347598 [details] WIP
Myles C. Maxfield
Comment 2 2018-08-21 13:03:52 PDT
Created attachment 347673 [details] WIP
Myles C. Maxfield
Comment 3 2018-08-21 15:58:46 PDT
Created attachment 347718 [details] WIP
Myles C. Maxfield
Comment 4 2018-08-21 19:26:12 PDT
Created attachment 347754 [details] WIP
Myles C. Maxfield
Comment 5 2018-08-21 19:39:20 PDT
Created attachment 347757 [details] WIP
Myles C. Maxfield
Comment 6 2018-08-21 21:55:51 PDT
Comment on attachment 347757 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=347757&action=review > Tools/WebGPUShadingLanguageRI/Checker.js:257 > + if (!node.type || !node.type.visit) node.type.visit > Tools/WebGPUShadingLanguageRI/checkTypesWithArguments.js:27 > +function checkTypesWithArguments(program) File name needs to be capitalized
Myles C. Maxfield
Comment 7 2018-08-21 21:57:58 PDT
Comment on attachment 347757 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=347757&action=review > Tools/WebGPUShadingLanguageRI/Checker.js:259 > + if (!(node.type instanceof StructType)) // FIXME: Why don't we recurse on StructTypes? Can we fix this? > Tools/WebGPUShadingLanguageRI/Intrinsics.js:68 > + // FIXME: Make this math obey IEEE 754. Test this > Tools/WebGPUShadingLanguageRI/Intrinsics.js:316 > + // FIXME: Figure out what to put here. Perhaps delete the comment > Tools/WebGPUShadingLanguageRI/StandardLibrary.js:205 > // FIXME: Once the standard library has been replaced with a new version, this comments should be removed. bugzilla link? > Tools/WebGPUShadingLanguageRI/TypeRef.js:101 > + // FIXME: This is probably wrong. Let's see if we can figure out a way to do this better.
Myles C. Maxfield
Comment 8 2018-08-22 13:32:58 PDT
Created attachment 347837 [details] Needs tests
Myles C. Maxfield
Comment 9 2018-08-22 14:21:52 PDT
Created attachment 347846 [details] Setting .type in Checker will break TypeDefResolver
Myles C. Maxfield
Comment 10 2018-08-22 15:48:59 PDT
Created attachment 347863 [details] Patch
WebKit Commit Bot
Comment 11 2018-08-23 12:52:23 PDT
Comment on attachment 347863 [details] Patch Clearing flags on attachment: 347863 Committed r235237: <https://trac.webkit.org/changeset/235237>
WebKit Commit Bot
Comment 12 2018-08-23 12:52:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2018-08-23 12:53:34 PDT
<rdar://problem/43654376>
Myles C. Maxfield
Comment 14 2018-10-13 15:26:19 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/92
Note You need to log in before you can comment on or make changes to this bug.