Bug 188773 - [WHLSL] Allow native types to have type arguments (like "vector<float, 4>")
Summary: [WHLSL] Allow native types to have type arguments (like "vector<float, 4>")
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 176199
  Show dependency tree / graph
 
Reported: 2018-08-20 19:39 PDT by Myles C. Maxfield
Modified: 2018-10-13 15:26 PDT (History)
7 users (show)

See Also:

Attachments
WIP (37.49 KB, patch)
2018-08-20 19:39 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
WIP (54.25 KB, patch)
2018-08-21 13:03 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
WIP (65.44 KB, patch)
2018-08-21 15:58 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
WIP (75.23 KB, patch)
2018-08-21 19:26 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
WIP (72.82 KB, patch)
2018-08-21 19:39 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Needs tests (72.76 KB, patch)
2018-08-22 13:32 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Setting .type in Checker will break TypeDefResolver (78.11 KB, patch)
2018-08-22 14:21 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (78.77 KB, patch)
2018-08-22 15:48 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-08-20 19:39:12 PDT 
[WHLSL] Allow native types to have type arguments (like "vector<float, 4>")
Comment 1 Myles C. Maxfield 2018-08-20 19:39:46 PDT 
Created attachment 347598 [details]
WIP
Comment 2 Myles C. Maxfield 2018-08-21 13:03:52 PDT 
Created attachment 347673 [details]
WIP
Comment 3 Myles C. Maxfield 2018-08-21 15:58:46 PDT 
Created attachment 347718 [details]
WIP
Comment 4 Myles C. Maxfield 2018-08-21 19:26:12 PDT 
Created attachment 347754 [details]
WIP
Comment 5 Myles C. Maxfield 2018-08-21 19:39:20 PDT 
Created attachment 347757 [details]
WIP
Comment 6 Myles C. Maxfield 2018-08-21 21:55:51 PDT 
Comment on attachment 347757 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=347757&action=review

> Tools/WebGPUShadingLanguageRI/Checker.js:257
> +        if (!node.type || !node.type.visit)

node.type.visit

> Tools/WebGPUShadingLanguageRI/checkTypesWithArguments.js:27
> +function checkTypesWithArguments(program)

File name needs to be capitalized
Comment 7 Myles C. Maxfield 2018-08-21 21:57:58 PDT 
Comment on attachment 347757 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=347757&action=review

> Tools/WebGPUShadingLanguageRI/Checker.js:259
> +        if (!(node.type instanceof StructType)) // FIXME: Why don't we recurse on StructTypes?

Can we fix this?

> Tools/WebGPUShadingLanguageRI/Intrinsics.js:68
> +            // FIXME: Make this math obey IEEE 754.

Test this

> Tools/WebGPUShadingLanguageRI/Intrinsics.js:316
> +                    // FIXME: Figure out what to put here.

Perhaps delete the comment

> Tools/WebGPUShadingLanguageRI/StandardLibrary.js:205
>  // FIXME: Once the standard library has been replaced with a new version, this comments should be removed.

bugzilla link?

> Tools/WebGPUShadingLanguageRI/TypeRef.js:101
> +                // FIXME: This is probably wrong.

Let's see if we can figure out a way to do this better.
Comment 8 Myles C. Maxfield 2018-08-22 13:32:58 PDT 
Created attachment 347837 [details]
Needs tests
Comment 9 Myles C. Maxfield 2018-08-22 14:21:52 PDT 
Created attachment 347846 [details]
Setting .type in Checker will break TypeDefResolver
Comment 10 Myles C. Maxfield 2018-08-22 15:48:59 PDT 
Created attachment 347863 [details]
Patch
Comment 11 WebKit Commit Bot 2018-08-23 12:52:23 PDT 
Comment on attachment 347863 [details]
Patch

Clearing flags on attachment: 347863

Committed r235237: <https://trac.webkit.org/changeset/235237>
Comment 12 WebKit Commit Bot 2018-08-23 12:52:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2018-08-23 12:53:34 PDT 
<rdar://problem/43654376>
Comment 14 Myles C. Maxfield 2018-10-13 15:26:19 PDT 
Migrated to https://github.com/gpuweb/WHLSL/issues/92