[WHLSL] Allow native types to have type arguments (like "vector<float, 4>")
Created attachment 347598 [details] WIP
Created attachment 347673 [details] WIP
Created attachment 347718 [details] WIP
Created attachment 347754 [details] WIP
Created attachment 347757 [details] WIP
Comment on attachment 347757 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=347757&action=review > Tools/WebGPUShadingLanguageRI/Checker.js:257 > + if (!node.type || !node.type.visit) node.type.visit > Tools/WebGPUShadingLanguageRI/checkTypesWithArguments.js:27 > +function checkTypesWithArguments(program) File name needs to be capitalized
Comment on attachment 347757 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=347757&action=review > Tools/WebGPUShadingLanguageRI/Checker.js:259 > + if (!(node.type instanceof StructType)) // FIXME: Why don't we recurse on StructTypes? Can we fix this? > Tools/WebGPUShadingLanguageRI/Intrinsics.js:68 > + // FIXME: Make this math obey IEEE 754. Test this > Tools/WebGPUShadingLanguageRI/Intrinsics.js:316 > + // FIXME: Figure out what to put here. Perhaps delete the comment > Tools/WebGPUShadingLanguageRI/StandardLibrary.js:205 > // FIXME: Once the standard library has been replaced with a new version, this comments should be removed. bugzilla link? > Tools/WebGPUShadingLanguageRI/TypeRef.js:101 > + // FIXME: This is probably wrong. Let's see if we can figure out a way to do this better.
Created attachment 347837 [details] Needs tests
Created attachment 347846 [details] Setting .type in Checker will break TypeDefResolver
Created attachment 347863 [details] Patch
Comment on attachment 347863 [details] Patch Clearing flags on attachment: 347863 Committed r235237: <https://trac.webkit.org/changeset/235237>
All reviewed patches have been landed. Closing bug.
<rdar://problem/43654376>
Migrated to https://github.com/gpuweb/WHLSL/issues/92