Bug 188738 - [GTK] Sort inspector GResource manifest to ensure reproducible builds
Summary: [GTK] Sort inspector GResource manifest to ensure reproducible builds
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2018-08-19 21:57 PDT by Bernhard M. Wiedemann
Modified: 2018-08-20 09:49 PDT (History)
4 users (show)

See Also:

fixing patch (871 bytes, patch)
2018-08-19 22:02 PDT, Bernhard M. Wiedemann
aperez: review-
Details | Formatted Diff | Diff
patch with changelog entry (1.71 KB, patch)
2018-08-20 07:18 PDT, Bernhard M. Wiedemann
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bernhard M. Wiedemann 2018-08-19 21:57:40 PDT
bug 174540 occurred again in openSUSE's webkit2gtk3 package (even though webkitgtk and webkitgtk3 packages are dropped)
Comment 1 Bernhard M. Wiedemann 2018-08-19 22:02:19 PDT
Created attachment 347480 [details]
fixing patch
Comment 2 Adrian Perez 2018-08-20 02:42:35 PDT
Comment on attachment 347480 [details]
fixing patch

Hi Bernhard! I think it would be fine to merge the patchit, but it would
need to follow the convention of including a ChangeLog entry. You can
generate one for your changes using “Tools/Scripts/prepare-ChangeLog”. If
you have a Git checkout, you can pass “-g <commitish>” to indicate for
which commit(s) the entry will be generated.

Could you please be so kind as to add the ChangeLog entry and re-submit
the patch? Thanks in advance!
Comment 3 Bernhard M. Wiedemann 2018-08-20 07:18:57 PDT
Created attachment 347495 [details]
patch with changelog entry
Comment 4 Michael Catanzaro 2018-08-20 07:21:52 PDT
Comment on attachment 347495 [details]
patch with changelog entry

In the future, you can use the r? and cq? flags to request review and commit, respectively.
Comment 5 WebKit Commit Bot 2018-08-20 09:49:17 PDT
Comment on attachment 347495 [details]
patch with changelog entry

Clearing flags on attachment: 347495

Committed r235080: <https://trac.webkit.org/changeset/235080>
Comment 6 WebKit Commit Bot 2018-08-20 09:49:19 PDT
All reviewed patches have been landed.  Closing bug.