Bug 174540 – [GTK] Sort inspector GResource manifest to ensure reproducible builds

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Bernhard M. Wiedemann]

When building the webkitgtk3 package for openSUSE,
it produces random variations in the resulting libwebkitgtk-3.0.so.0.22.17
because GResourceBundle.xml is generated via python's glob.glob function
that returns entries in undeterministic filesystem order.

[Bernhard M. Wiedemann]

Created attachment 315536 [details]
fixing patch

[Adrian Perez]

Comment on attachment 315536 [details]
fixing patch

Informal review: I would r+ this without doubt.

Also: Having reproducible builds is IMHO a noble goal, so we should
help from our side merging patches upstream whenever possible :-)

[Adrian Perez]

Bernhard: I have CC'd a few people to try and get the patch landed. If
you used “webkit-patch upload”, a one nice tip for next time is passing
“--suggest-reviewers --request-commit” to it, which will get reviewers
CC'd automatically, and ask the automated commit-queue to land your patch.

And many thanks for posting the patch!

[Michael Catanzaro]

Thanks. It also needs a ChangeLog entry ('Tools/Scripts/prepare-ChangeLog -b 174540')

[Michael Catanzaro]

Also note that Fedora and Debian have both removed their old/insecure webkitgtk3 packages. Now would be a good time for openSUSE to follow suit.

[Bernhard M. Wiedemann]

Created attachment 315565 [details]
patch with changelog entry

[Michael Catanzaro]

Sorry, I forgot to change the title... please change the title in the ChangeLog, then we can land this.

[Bernhard M. Wiedemann]

Created attachment 315594 [details]
patch with updated changelog entry

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 315594 [details]:

storage/indexeddb/modern/new-database-after-user-delete.html bug 174354 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 315594 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 315594 [details]
patch with updated changelog entry

Clearing flags on attachment: 315594

Committed r219546: <http://trac.webkit.org/changeset/219546>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.