Bug 188241 – Make sure cookies get flushed to disk before exiting or suspending the network process

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Make sure cookies get flushed to disk before exiting or suspending the network process.

[Chris Dumez]

Created attachment 346306 [details]
Patch

[EWS Watchlist]

Attachment 346306 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:215:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

<rdar://problem/42831831>

[Chris Dumez]

Comment on attachment 346306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346306&action=review

> Source/WebKit/Shared/ChildProcess.cpp:72
> +    WorkQueue::create("com.apple.WebKit.ChildProcess.WatchDogQueue")->dispatchAfter(watchdogDelay, [] {

This is a partial rollout of https://trac.webkit.org/changeset/231348/webkit to give the Network process a chance to sync cookies before exit.

[Geoffrey Garen]

r=me too

[Chris Dumez]

*** Bug 188236 has been marked as a duplicate of this bug. ***

[Chris Dumez]

Created attachment 346311 [details]
Patch

[EWS Watchlist]

Attachment 346311 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:215:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 346311 [details]
Patch

Clearing flags on attachment: 346311

Committed r234486: <https://trac.webkit.org/changeset/234486>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.