Bug 188236 - [iOS] Make sure cookies get sync'd to disk before the network process gets suspended
Summary: [iOS] Make sure cookies get sync'd to disk before the network process gets su...
Status: RESOLVED DUPLICATE of bug 188241
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-01 13:47 PDT by Chris Dumez
Modified: 2018-08-01 16:03 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.72 KB, patch)
2018-08-01 13:50 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (3.71 KB, patch)
2018-08-01 13:51 PDT, Chris Dumez
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-08-01 13:47:55 PDT
Make sure cookies get sync'd to disk before the network process gets suspended on iOS, to avoid loosing them.
Comment 1 Chris Dumez 2018-08-01 13:50:31 PDT
Created attachment 346295 [details]
Patch
Comment 2 Chris Dumez 2018-08-01 13:51:06 PDT
Created attachment 346296 [details]
Patch
Comment 3 EWS Watchlist 2018-08-01 13:54:00 PDT
Attachment 346296 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:215:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Alex Christensen 2018-08-01 13:54:13 PDT
Comment on attachment 346296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346296&action=review

> Source/WebKit/ChangeLog:3
> +        [iOS] Make sure cookies get sync'd to disk before the network process gets suspended

This doesn't seem iOS specific.
Comment 5 Chris Dumez 2018-08-01 16:03:58 PDT

*** This bug has been marked as a duplicate of bug 188241 ***