Bug 188130 - [Curl] Fix the bug when client reject the redirect on WebKitLegacy.
Summary: [Curl] Fix the bug when client reject the redirect on WebKitLegacy.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on: 188129
Blocks:
  Show dependency tree / graph
 
Reported: 2018-07-27 16:08 PDT by Basuke Suzuki
Modified: 2018-07-29 09:20 PDT (History)
9 users (show)

See Also:

Attachments
PATCH (2.92 KB, patch)
2018-07-27 17:09 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
PATCH (2.92 KB, patch)
2018-07-27 17:36 PDT, Basuke Suzuki 		darin: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (13.14 MB, application/zip)
2018-07-28 13:15 PDT, EWS Watchlist 		no flags Details
LANDING (2.92 KB, patch)
2018-07-29 08:38 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2018-07-27 16:08:38 PDT 
When ResourceHandleClient rejects redirection by passing empty request to the completion handler, it should exit immediately. NetworkDataTask do the right thing already. WebKitLegacy bug.
Comment 1 Basuke Suzuki 2018-07-27 17:09:47 PDT 
Created attachment 345977 [details]
PATCH
Comment 2 Basuke Suzuki 2018-07-27 17:36:17 PDT 
Created attachment 345980 [details]
PATCH
Comment 3 EWS Watchlist 2018-07-28 13:15:15 PDT 
Comment on attachment 345980 [details]
PATCH

Attachment 345980 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8684766

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
Comment 4 EWS Watchlist 2018-07-28 13:15:26 PDT 
Created attachment 345997 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Basuke Suzuki 2018-07-29 08:38:56 PDT 
Created attachment 346031 [details]
LANDING

Thanks Darin for r+
Comment 6 WebKit Commit Bot 2018-07-29 09:18:40 PDT 
Comment on attachment 346031 [details]
LANDING

Clearing flags on attachment: 346031

Committed r234346: <https://trac.webkit.org/changeset/234346>
Comment 7 WebKit Commit Bot 2018-07-29 09:18:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-07-29 09:20:17 PDT 
<rdar://problem/42709525>