Bug 188129 - [Curl] Test gardening
Summary: [Curl] Test gardening
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 188130
  Show dependency treegraph
 
Reported: 2018-07-27 16:00 PDT by Basuke Suzuki
Modified: 2018-07-27 17:36 PDT (History)
4 users (show)

See Also:


Attachments
PATCH (2.06 KB, patch)
2018-07-27 16:42 PDT, Basuke Suzuki
commit-queue: commit-queue-
Details | Formatted Diff | Diff
PATCH (2.06 KB, patch)
2018-07-27 16:49 PDT, Basuke Suzuki
commit-queue: commit-queue-
Details | Formatted Diff | Diff
PATCH (2.06 KB, patch)
2018-07-27 16:56 PDT, Basuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2018-07-27 16:00:45 PDT
Gardening for fixing a redirect bug on Curl port.
Comment 1 Basuke Suzuki 2018-07-27 16:42:08 PDT
Created attachment 345970 [details]
PATCH
Comment 2 WebKit Commit Bot 2018-07-27 16:43:05 PDT
Comment on attachment 345970 [details]
PATCH

Rejecting attachment 345970 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 345970, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/8678114
Comment 3 Basuke Suzuki 2018-07-27 16:49:44 PDT
Created attachment 345972 [details]
PATCH
Comment 4 WebKit Commit Bot 2018-07-27 16:50:37 PDT
Comment on attachment 345972 [details]
PATCH

Rejecting attachment 345972 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 345972, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Traceback (most recent call last):
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: https://webkit-queues.webkit.org/results/8678224
Comment 5 Basuke Suzuki 2018-07-27 16:56:00 PDT
Created attachment 345974 [details]
PATCH
Comment 6 WebKit Commit Bot 2018-07-27 17:35:29 PDT
Comment on attachment 345974 [details]
PATCH

Clearing flags on attachment: 345974

Committed r234341: <https://trac.webkit.org/changeset/234341>
Comment 7 WebKit Commit Bot 2018-07-27 17:35:30 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-07-27 17:36:18 PDT
<rdar://problem/42681538>