Bug 187812 - Temporarily mitigate a bug where a source provider is null when it shouldn't be.
Summary: Temporarily mitigate a bug where a source provider is null when it shouldn't be.
Status: RESOLVED DUPLICATE of bug 187359
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on: 187815
Blocks:
  Show dependency tree / graph
 
Reported: 2018-07-19 11:14 PDT by Mark Lam
Modified: 2018-07-19 12:44 PDT (History)
8 users (show)

See Also:

Attachments
proposed patch. (2.14 KB, patch)
2018-07-19 11:22 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
proposed patch. (2.13 KB, patch)
2018-07-19 11:23 PDT, Mark Lam 		msaboff: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-07-19 11:14:10 PDT 
Adding a null check to temporarily mitigate https://bugs.webkit.org/show_bug.cgi?id=187811.

<rdar://problem/41192691>
Comment 1 Radar WebKit Bug Importer 2018-07-19 11:15:23 PDT 
<rdar://problem/42391474>
Comment 2 Mark Lam 2018-07-19 11:15:46 PDT 
<rdar://problem/41192691>
Comment 3 Mark Lam 2018-07-19 11:22:17 PDT 
Created attachment 345362 [details]
proposed patch.
Comment 4 Mark Lam 2018-07-19 11:23:32 PDT 
Created attachment 345363 [details]
proposed patch.
Comment 5 Michael Saboff 2018-07-19 11:33:51 PDT 
Comment on attachment 345363 [details]
proposed patch.

r=me
Comment 6 Saam Barati 2018-07-19 12:27:19 PDT 
Comment on attachment 345363 [details]
proposed patch.

I thought I already fixed this bug? I’m pretty sure the issue here is the underlying codeblock was being collected.

Maybe the bug here is we’re forgetting to copy the SourceCode instead of passing it by reference. Do you know if my previous fix fixed this issue? Or do we not have data to say.
Comment 7 Mark Lam 2018-07-19 12:29:30 PDT 
Thanks for the review.  Landed in r233998: <http://trac.webkit.org/r233998>.
Comment 8 Mark Lam 2018-07-19 12:30:01 PDT 
(In reply to Saam Barati from comment #6)
> Comment on attachment 345363 [details]
> proposed patch.
> 
> I thought I already fixed this bug? I’m pretty sure the issue here is the
> underlying codeblock was being collected.
> 
> Maybe the bug here is we’re forgetting to copy the SourceCode instead of
> passing it by reference. Do you know if my previous fix fixed this issue? Or
> do we not have data to say.

I don't have data on that.  Which bug are you referring to?  I can take a look.
Comment 9 Mark Lam 2018-07-19 12:36:40 PDT 
(In reply to Mark Lam from comment #8)
> (In reply to Saam Barati from comment #6)
> > Comment on attachment 345363 [details]
> > proposed patch.
> > 
> > I thought I already fixed this bug? I’m pretty sure the issue here is the
> > underlying codeblock was being collected.
> > 
> > Maybe the bug here is we’re forgetting to copy the SourceCode instead of
> > passing it by reference. Do you know if my previous fix fixed this issue? Or
> > do we not have data to say.
> 
> I don't have data on that.  Which bug are you referring to?  I can take a
> look.

Found the bug.  Investigating now.
Comment 10 Saam Barati 2018-07-19 12:37:15 PDT 
Seems very likely it’s the same. This is the same symptom I saw
Comment 11 Mark Lam 2018-07-19 12:39:14 PDT 
(In reply to Saam Barati from comment #10)
> Seems very likely it’s the same. This is the same symptom I saw

Yep.  Total duplicate.  Will roll out my mitigation.  No wonder I don't see what's wrong in the source: it's already fixed.
Comment 12 WebKit Commit Bot 2018-07-19 12:39:58 PDT 
Re-opened since this is blocked by bug 187815
Comment 13 Mark Lam 2018-07-19 12:44:14 PDT 
The unneeded mitigation was rolled out in r233999: <https://trac.webkit.org/changeset/233999>.
Comment 14 Mark Lam 2018-07-19 12:44:34 PDT 

*** This bug has been marked as a duplicate of bug 187359 ***