RESOLVED DUPLICATE of bug 187359 187812
Temporarily mitigate a bug where a source provider is null when it shouldn't be. 
https://bugs.webkit.org/show_bug.cgi?id=187812
Summary Temporarily mitigate a bug where a source provider is null when it shouldn't be.
Mark Lam
Reported 2018-07-19 11:14:10 PDT
Adding a null check to temporarily mitigate https://bugs.webkit.org/show_bug.cgi?id=187811. <rdar://problem/41192691>
Attachments
proposed patch. (2.14 KB, patch)
2018-07-19 11:22 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (2.13 KB, patch)
2018-07-19 11:23 PDT, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-07-19 11:15:23 PDT
<rdar://problem/42391474>
Mark Lam
Comment 2 2018-07-19 11:15:46 PDT
<rdar://problem/41192691>
Mark Lam
Comment 3 2018-07-19 11:22:17 PDT
Created attachment 345362 [details] proposed patch.
Mark Lam
Comment 4 2018-07-19 11:23:32 PDT
Created attachment 345363 [details] proposed patch.
Michael Saboff
Comment 5 2018-07-19 11:33:51 PDT
Comment on attachment 345363 [details] proposed patch. r=me
Saam Barati
Comment 6 2018-07-19 12:27:19 PDT
Comment on attachment 345363 [details] proposed patch. I thought I already fixed this bug? I’m pretty sure the issue here is the underlying codeblock was being collected. Maybe the bug here is we’re forgetting to copy the SourceCode instead of passing it by reference. Do you know if my previous fix fixed this issue? Or do we not have data to say.
Mark Lam
Comment 7 2018-07-19 12:29:30 PDT
Thanks for the review. Landed in r233998: <http://trac.webkit.org/r233998>.
Mark Lam
Comment 8 2018-07-19 12:30:01 PDT
(In reply to Saam Barati from comment #6) > Comment on attachment 345363 [details] > proposed patch. > > I thought I already fixed this bug? I’m pretty sure the issue here is the > underlying codeblock was being collected. > > Maybe the bug here is we’re forgetting to copy the SourceCode instead of > passing it by reference. Do you know if my previous fix fixed this issue? Or > do we not have data to say. I don't have data on that. Which bug are you referring to? I can take a look.
Mark Lam
Comment 9 2018-07-19 12:36:40 PDT
(In reply to Mark Lam from comment #8) > (In reply to Saam Barati from comment #6) > > Comment on attachment 345363 [details] > > proposed patch. > > > > I thought I already fixed this bug? I’m pretty sure the issue here is the > > underlying codeblock was being collected. > > > > Maybe the bug here is we’re forgetting to copy the SourceCode instead of > > passing it by reference. Do you know if my previous fix fixed this issue? Or > > do we not have data to say. > > I don't have data on that. Which bug are you referring to? I can take a > look. Found the bug. Investigating now.
Saam Barati
Comment 10 2018-07-19 12:37:15 PDT
Seems very likely it’s the same. This is the same symptom I saw
Mark Lam
Comment 11 2018-07-19 12:39:14 PDT
(In reply to Saam Barati from comment #10) > Seems very likely it’s the same. This is the same symptom I saw Yep. Total duplicate. Will roll out my mitigation. No wonder I don't see what's wrong in the source: it's already fixed.
WebKit Commit Bot
Comment 12 2018-07-19 12:39:58 PDT
Re-opened since this is blocked by bug 187815
Mark Lam
Comment 13 2018-07-19 12:44:14 PDT
The unneeded mitigation was rolled out in r233999: <https://trac.webkit.org/changeset/233999>.
Mark Lam
Comment 14 2018-07-19 12:44:34 PDT
*** This bug has been marked as a duplicate of bug 187359 ***
Note You need to log in before you can comment on or make changes to this bug.