Bug 187359 - ProgramExecutable may be collected as we checkSyntax on it
Summary: ProgramExecutable may be collected as we checkSyntax on it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
: 187811 187812 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-07-05 12:53 PDT by Saam Barati
Modified: 2018-07-19 12:45 PDT (History)
13 users (show)

See Also:

Attachments
patch (1.69 KB, patch)
2018-07-05 13:35 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-07-05 12:53:09 PDT 
The reason this is bad is we call into various functions with a  reference to one of ProgramExecutable's fields.
We either need to:
- drop in a use() on it 
- Copy the field instead of passing a reference
- defer GC
(I like the first option)

This is already caught by our iOS JSC testing on various tests.
Comment 1 Saam Barati 2018-07-05 13:21:02 PDT 
Actually, let's do (2)
Comment 2 Saam Barati 2018-07-05 13:28:15 PDT 
<rdar://problem/41832135>
Comment 3 Saam Barati 2018-07-05 13:35:15 PDT 
Created attachment 344358 [details]
patch
Comment 4 Mark Lam 2018-07-05 13:36:26 PDT 
Comment on attachment 344358 [details]
patch

r=me
Comment 5 WebKit Commit Bot 2018-07-05 14:35:16 PDT 
Comment on attachment 344358 [details]
patch

Clearing flags on attachment: 344358

Committed r233540: <https://trac.webkit.org/changeset/233540>
Comment 6 WebKit Commit Bot 2018-07-05 14:35:18 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Mark Lam 2018-07-19 12:44:34 PDT 
*** Bug 187812 has been marked as a duplicate of this bug. ***
Comment 8 Mark Lam 2018-07-19 12:45:11 PDT 
*** Bug 187811 has been marked as a duplicate of this bug. ***