RESOLVED FIXED 187359
ProgramExecutable may be collected as we checkSyntax on it 
https://bugs.webkit.org/show_bug.cgi?id=187359
Summary ProgramExecutable may be collected as we checkSyntax on it
Saam Barati
Reported 2018-07-05 12:53:09 PDT
The reason this is bad is we call into various functions with a reference to one of ProgramExecutable's fields. We either need to: - drop in a use() on it - Copy the field instead of passing a reference - defer GC (I like the first option) This is already caught by our iOS JSC testing on various tests.
Attachments
patch (1.69 KB, patch)
2018-07-05 13:35 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2018-07-05 13:21:02 PDT
Actually, let's do (2)
Saam Barati
Comment 2 2018-07-05 13:28:15 PDT
<rdar://problem/41832135>
Saam Barati
Comment 3 2018-07-05 13:35:15 PDT
Created attachment 344358 [details] patch
Mark Lam
Comment 4 2018-07-05 13:36:26 PDT
Comment on attachment 344358 [details] patch r=me
WebKit Commit Bot
Comment 5 2018-07-05 14:35:16 PDT
Comment on attachment 344358 [details] patch Clearing flags on attachment: 344358 Committed r233540: <https://trac.webkit.org/changeset/233540>
WebKit Commit Bot
Comment 6 2018-07-05 14:35:18 PDT
All reviewed patches have been landed. Closing bug.
Mark Lam
Comment 7 2018-07-19 12:44:34 PDT
*** Bug 187812 has been marked as a duplicate of this bug. ***
Mark Lam
Comment 8 2018-07-19 12:45:11 PDT
*** Bug 187811 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.