Bug 187672 - Replace TR2_OPTIONAL_ASSERTED_EXPRESSION macro in <wtf/Optional.h>
Summary: Replace TR2_OPTIONAL_ASSERTED_EXPRESSION macro in <wtf/Optional.h>
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2018-07-13 16:59 PDT by David Kilzer (:ddkilzer)
Modified: 2018-07-14 10:01 PDT (History)
11 users (show)

See Also:

Patch v1 (3.37 KB, patch)
2018-07-13 17:23 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2018-07-13 16:59:41 PDT
Replace the TR2_OPTIONAL_ASSERTED_EXPRESSION macro in <wtf/Optional.h> since we can use ASSERT_UNDER_CONSTEXPR_CONTEXT() instead.

Makes all the assertions more consistent within the class.
Comment 1 David Kilzer (:ddkilzer) 2018-07-13 17:23:20 PDT
Created attachment 345007 [details]
Patch v1
Comment 2 Frédéric Wang (:fredw) 2018-07-13 23:44:01 PDT
Comment on attachment 345007 [details]
Patch v1

Yes, I guess the only reason we have this is because we copied it from https://github.com/akrzemi1/Optional/blob/master/optional.hpp#L199.
Comment 3 WebKit Commit Bot 2018-07-14 10:00:01 PDT
Comment on attachment 345007 [details]
Patch v1

Clearing flags on attachment: 345007

Committed r233836: <https://trac.webkit.org/changeset/233836>
Comment 4 WebKit Commit Bot 2018-07-14 10:00:03 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-07-14 10:01:18 PDT