Bug 187331 - [ews-build] WebKitPy-Tests-EWS should output result in json
Summary: [ews-build] WebKitPy-Tests-EWS should output result in json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-04 14:01 PDT by Aakash Jain
Modified: 2018-09-07 10:56 PDT (History)
5 users (show)

See Also:


Attachments
Proposed patch (2.75 KB, patch)
2018-07-04 14:04 PDT, Aakash Jain
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-07-04 14:01:19 PDT
WebKitPy-Tests-EWS should output result in json format. This would be useful in easily parsing the errors.
Comment 1 Aakash Jain 2018-07-04 14:04:40 PDT
Created attachment 344300 [details]
Proposed patch

Sample run: http://ews-build.webkit-uat.org/#/builders/16/builds/26
Comment 2 David Kilzer (:ddkilzer) 2018-07-05 10:19:02 PDT
Comment on attachment 344300 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344300&action=review

r=me

> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:313
> +                        command=['Tools/Scripts/test-webkitpy', '--json-output=webkitpy_test_results.json'],
> +                        logfiles={'json': 'webkitpy_test_results.json'},

Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done in steps.py.

> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:326
> +                        command=['Tools/Scripts/test-webkitpy', '--json-output=webkitpy_test_results.json'],
> +                        logfiles={'json': 'webkitpy_test_results.json'},

Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done in steps.py.
Comment 3 Aakash Jain 2018-07-05 10:25:43 PDT
(In reply to David Kilzer (:ddkilzer) from comment #2)
> Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done
> in steps.py.
Sure, will re-use the variable.
Comment 4 Aakash Jain 2018-07-05 10:26:51 PDT
Committed r233527: <https://trac.webkit.org/changeset/233527>.
Comment 5 Radar WebKit Bug Importer 2018-07-05 10:34:44 PDT
<rdar://problem/41853334>
Comment 6 Aakash Jain 2018-07-05 11:38:17 PDT
Committed r233528.