We should add support for WebKitPy-Tests-EWS in EWS Buildbot.
Any concerns about certain platforms failing WebKit python tests? I know Windows without cygwin has problems still.
Created attachment 343827 [details] Proposed patch
Attachment 343827 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:314: [TestunWebKitPyTests.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:314: [TestunWebKitPyTests.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:327: [TestunWebKitPyTests.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:327: [TestunWebKitPyTests.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to Don Olmstead from comment #1) > Any concerns about certain platforms failing WebKit python tests? I know > Windows without cygwin has problems still. The current plan is to run this webkitpy EWS on a macOS machine. We might consider running webkitpy tests on multiple platforms in future.
(In reply to Aakash Jain from comment #4) > (In reply to Don Olmstead from comment #1) > > Any concerns about certain platforms failing WebKit python tests? I know > > Windows without cygwin has problems still. > The current plan is to run this webkitpy EWS on a macOS machine. We might > consider running webkitpy tests on multiple platforms in future. Ok cool. We'd be interested in doing a bot. The only concern is that it wouldn't get too much work to do. If EWS goes Buildbot then a latent worker would probably make sense.
Comment on attachment 343827 [details] Proposed patch Informal review looks good to me. One thing you might want to consider is expanding the space in Bugzilla for the EWS bubbles. It currently cuts things off currently and more bots just make things worse.
(In reply to Don Olmstead from comment #5) > Ok cool. We'd be interested in doing a bot. The only concern is that it > wouldn't get too much work to do. If EWS goes Buildbot then a latent worker would probably make sense. Yes, I am working on EWS Buildbot configuration. See: http://ews-build.webkit-uat.org/#/builders We can explore using latent worker, that make sense. > Informal review looks good to me. Thanks > One thing you might want to consider is expanding the space in Bugzilla for the EWS bubbles. Yes, I will take care of that soon.
Comment on attachment 343827 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=343827&action=review r=me after fixing type and ensuring unit tests run. > Tools/BuildSlaveSupport/ews-build/steps_unittest.py:298 > +class TestunWebKitPyTests(BuildStepMixinAdditions, unittest.TestCase): typo here
Committed r233318: <https://trac.webkit.org/changeset/233318>.
<rdar://problem/41595909>