Bug 187330 - [ews-build] Bindings-tests-EWS should output result in json
Summary: [ews-build] Bindings-tests-EWS should output result in json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-04 13:56 PDT by Aakash Jain
Modified: 2018-09-07 10:54 PDT (History)
5 users (show)

See Also:


Attachments
Proposed patch (2.68 KB, patch)
2018-07-04 14:00 PDT, Aakash Jain
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-07-04 13:56:45 PDT
Bindings-tests-EWS should output result in json. This would be useful in easily parsing the errors.
Comment 1 Aakash Jain 2018-07-04 14:00:03 PDT
Created attachment 344299 [details]
Proposed patch

Sample run: http://ews-build.webkit-uat.org/#/builders/14/builds/22
Comment 2 David Kilzer (:ddkilzer) 2018-07-05 10:18:25 PDT
Comment on attachment 344299 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344299&action=review

r=me

> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:244
> +                        command=['Tools/Scripts/run-bindings-tests', '--json-output=bindings_test_results.json'],
> +                        logfiles={'json': 'bindings_test_results.json'},

Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done in steps.py.

> Tools/BuildSlaveSupport/ews-build/steps_unittest.py:256
> +                        command=['Tools/Scripts/run-bindings-tests', '--json-output=bindings_test_results.json'],
> +                        logfiles={'json': 'bindings_test_results.json'},

Nit: Don't repeat yourself by extracting `jsonFileName` variable as is done in steps.py.
Comment 3 Aakash Jain 2018-07-05 11:36:58 PDT
Committed r233531: <https://trac.webkit.org/changeset/233531>.
Comment 4 Radar WebKit Bug Importer 2018-07-05 11:37:20 PDT
<rdar://problem/41856838>