Bug 187014 - [ews-build] Add support for Bindings-tests-EWS
Summary: [ews-build] Add support for Bindings-tests-EWS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-25 13:52 PDT by Aakash Jain
Modified: 2018-07-05 09:47 PDT (History)
5 users (show)

See Also:


Attachments
Proposed patch (3.75 KB, patch)
2018-06-25 13:57 PDT, Aakash Jain
lforschler: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-06-25 13:52:24 PDT
We should add support for Binding-tests-EWS.
Comment 1 Aakash Jain 2018-06-25 13:57:49 PDT
Created attachment 343535 [details]
Proposed patch
Comment 2 EWS Watchlist 2018-06-25 14:00:50 PDT
Attachment 343535 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:247:  [TestRunBindingsTests.test_success] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:247:  [TestRunBindingsTests.test_success] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:259:  [TestRunBindingsTests.test_failure] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:259:  [TestRunBindingsTests.test_failure] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
Total errors found: 4 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Aakash Jain 2018-06-25 14:03:14 PDT
This is similar to what we use in other Buildbot code.

Also tested on ews-build.webkit-uat.org (http://ews-build.webkit-uat.org/#/builders/14/builds/5)
Comment 4 Aakash Jain 2018-06-25 14:03:58 PDT
style-queue warnings are false positive.
Comment 5 Aakash Jain 2018-06-25 14:28:51 PDT
Committed r233175: <https://trac.webkit.org/changeset/233175>
Comment 6 Radar WebKit Bug Importer 2018-06-25 14:31:10 PDT
<rdar://problem/41440190>