Bug 187113 - Don't invoke post resolution callbacks when resolving computed style
Summary: Don't invoke post resolution callbacks when resolving computed style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-27 12:49 PDT by Antti Koivisto
Modified: 2018-06-28 14:23 PDT (History)
9 users (show)

See Also:


Attachments
patch (8.86 KB, patch)
2018-06-27 13:17 PDT, Antti Koivisto
ggaren: review+
Details | Formatted Diff | Diff
patch (8.31 KB, patch)
2018-06-27 13:46 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-06-27 12:49:44 PDT
Post resolution callbacks should only be invoked when we actually resolve the document style.
Comment 1 Antti Koivisto 2018-06-27 12:50:17 PDT
<rdar://problem/41365766>
Comment 2 Antti Koivisto 2018-06-27 13:17:32 PDT
Created attachment 343745 [details]
patch
Comment 3 Geoffrey Garen 2018-06-27 13:23:37 PDT
Comment on attachment 343745 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343745&action=review

r=me

> LayoutTests/ChangeLog:24
> +2018-06-15  Antti Koivisto  <antti@apple.com>
> +
> +        Semantic colors should not be transformed by color-filter
> +        https://bugs.webkit.org/show_bug.cgi?id=186566
> +        <rdar://problem/40705739>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * css3/color-filters/color-filter-ignore-semantic-expected.html: Added.
> +        * css3/color-filters/color-filter-ignore-semantic.html: Added.
> +

Revert please.
Comment 4 Antti Koivisto 2018-06-27 13:46:44 PDT
Created attachment 343749 [details]
patch
Comment 5 WebKit Commit Bot 2018-06-27 15:25:37 PDT
Comment on attachment 343749 [details]
patch

Clearing flags on attachment: 343749

Committed r233281: <https://trac.webkit.org/changeset/233281>
Comment 6 WebKit Commit Bot 2018-06-27 15:25:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Truitt Savell 2018-06-28 10:34:12 PDT
it looks like after revision 233281 we started getting consistent timeouts on tests. 

Tests Timeout:
fast/dom/location-new-window-no-crash.html
http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-window-open.html	
storage/indexeddb/modern/blob-cursor.html
storage/indexeddb/modern/blob-svg-image.html

failure report:
https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r233306%20(5312)/results.html
Comment 8 Antti Koivisto 2018-06-28 14:22:37 PDT
https://bugs.webkit.org/show_bug.cgi?id=187156 for that