Bug 186566 – Semantic colors should not be transformed by color-filter

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Antti Koivisto]

Maybe?

[Brent Fulgham]

<rdar://problem/40705739>

[Antti Koivisto]

Created attachment 342559 [details]
patch

[EWS Watchlist]

Comment on attachment 342559 [details]
patch

Attachment 342559 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/8149356

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 342566 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 342559 [details]
patch

Attachment 342559 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/8150125

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 342580 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 342559 [details]
patch

Attachment 342559 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/8149543

New failing tests:
css3/color-filters/color-filter-ignore-semantic.html

[EWS Watchlist]

Created attachment 342582 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[EWS Watchlist]

Comment on attachment 342559 [details]
patch

Attachment 342559 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/8150388

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 342585 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Antti Koivisto]

Created attachment 342648 [details]
patch

[Antti Koivisto]

Created attachment 342649 [details]
patch

[EWS Watchlist]

Comment on attachment 342649 [details]
patch

Attachment 342649 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/8162912

New failing tests:
css3/color-filters/color-filter-ignore-semantic.html

[EWS Watchlist]

Created attachment 342654 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[Antti Koivisto]

Created attachment 342655 [details]
patch

[Timothy Hatcher]

Comment on attachment 342655 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342655&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:600
> +                return colorFromNSColor(color, Color::Semantic);

I added two more colorFromNSColor() uses in a patch that will land before this one. Please add Color::Semantic to those calls too. See bug 186609.

[Antti Koivisto]

Created attachment 342811 [details]
patch

[Simon Fraser (smfr)]

Comment on attachment 342811 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342811&action=review

> Source/WebCore/rendering/RenderTreeAsText.cpp:245
> -            if (o.parent()->style().visitedDependentColor(CSSPropertyColor) != color)
> +            if (o.parent()->style().visitedDependentColor(CSSPropertyColor).rgb() != color.rgb())

Really confusing that "rgb()" includes alpha. It looks like these comparisons are ignoring alpha.

Maybe add an explicit bool Color::rgbaEquals(const Color&) or something.

[Antti Koivisto]

> Really confusing that "rgb()" includes alpha. It looks like these
> comparisons are ignoring alpha.

Yeah, we can just rename it to rgba()

[WebKit Commit Bot]

Comment on attachment 342811 [details]
patch

Clearing flags on attachment: 342811

Committed r232892: <https://trac.webkit.org/changeset/232892>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.