Bug 186609 – Expose more semantic system colors

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Timothy Hatcher]

There are some colors missing that clients have asked for us to expose.

<rdar://problem/39287277>

[Timothy Hatcher]

Created attachment 342698 [details]
Patch

[Timothy Hatcher]

Created attachment 342700 [details]
Patch

[EWS Watchlist]

Comment on attachment 342700 [details]
Patch

Attachment 342700 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/8169878

New failing tests:
fast/css/apple-system-control-colors.html

[EWS Watchlist]

Created attachment 342709 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 342700 [details]
Patch

Attachment 342700 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/8169920

New failing tests:
fast/css/apple-system-control-colors.html

[EWS Watchlist]

Created attachment 342710 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 342700 [details]
Patch

Attachment 342700 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/8170077

New failing tests:
fast/css/apple-system-control-colors.html

[EWS Watchlist]

Created attachment 342712 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Timothy Hatcher]

Created attachment 342735 [details]
Patch

[EWS Watchlist]

Comment on attachment 342735 [details]
Patch

Attachment 342735 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/8180907

New failing tests:
fast/css/apple-system-control-colors.html

[EWS Watchlist]

Created attachment 342740 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Timothy Hatcher]

Created attachment 342743 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 342743 [details]
Patch

Clearing flags on attachment: 342743

Committed r232847: <https://trac.webkit.org/changeset/232847>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Matt Lewis]

This patch looks to have caused a failure in the test on all macOS High Sierra testers

http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fcss%2Fapple-system-control-colors.html

https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r232852%20(5062)/results.html

I'm wondering if based on the diff, that it is just a rebaseline.

diff:
--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/fast/css/apple-system-control-colors-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/fast/css/apple-system-control-colors-actual.txt
@@ -12,7 +12,7 @@
 -apple-system-selected-text-background : rgb(181, 213, 255)
 -apple-system-unemphasized-selected-text-background : rgb(212, 212, 212)
 -apple-system-placeholder-text : rgba(0, 0, 0, 0.247059)
--apple-system-find-highlight-background : rgb(255, 204, 0)
+-apple-system-find-highlight-background : rgb(255, 255, 0)
 -apple-system-label : rgba(0, 0, 0, 0.85098)
 -apple-system-secondary-label : rgba(0, 0, 0, 0.498039)
 -apple-system-tertiary-label : rgba(0, 0, 0, 0.247059)

[Timothy Hatcher]

See bug 186668 with updated results.