Bug 186961 - [Cocoa] Convert the small bit of Objective-C++ code in WTF to ARC
Summary: [Cocoa] Convert the small bit of Objective-C++ code in WTF to ARC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks: 221107 221108
  Show dependency tree / graph
 
Reported: 2018-06-22 21:44 PDT by Darin Adler
Modified: 2021-01-28 15:15 PST (History)
9 users (show)

See Also:

Attachments
Patch (4.36 KB, patch)
2018-06-22 21:45 PDT, Darin Adler 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2018-06-22 21:44:45 PDT 
[Cocoa] Convert the small bit of Objective-C++ code in WTF to ARC
Comment 1 Darin Adler 2018-06-22 21:45:38 PDT 
Created attachment 343419 [details]
Patch
Comment 2 Darin Adler 2018-06-23 08:30:40 PDT 
Committed r233128: <https://trac.webkit.org/changeset/233128>
Comment 3 Radar WebKit Bug Importer 2018-06-23 08:31:21 PDT 
<rdar://problem/41398383>
Comment 4 David Kilzer (:ddkilzer) 2018-07-01 15:36:29 PDT 
Comment on attachment 343419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343419&action=review

> Source/WTF/Configurations/Base.xcconfig:36
> +CLANG_ENABLE_OBJC_ARC = YES;
>  CLANG_ENABLE_OBJC_WEAK = YES;

Note that you can remove "CLANG_ENABLE_OBJC_WEAK = YES;" when enabling ARC, as -fobjc-arc is a superset of -fobjc-weak.
Comment 5 mitz 2018-07-01 15:39:22 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #4)
> Comment on attachment 343419 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=343419&action=review
> 
> > Source/WTF/Configurations/Base.xcconfig:36
> > +CLANG_ENABLE_OBJC_ARC = YES;
> >  CLANG_ENABLE_OBJC_WEAK = YES;
> 
> Note that you can remove "CLANG_ENABLE_OBJC_WEAK = YES;" when enabling ARC,
> as -fobjc-arc is a superset of -fobjc-weak.

See bug 186396 comment 2 and my response.