Bug 186396 – [Cocoa] Minor ARC tidying of libwebrtc

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Darin Adler]

[Cocoa] Minor ARC tidying of libwebrtc

[Darin Adler]

Created attachment 342173 [details]
Patch

[Darin Adler]

Comment on attachment 342173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342173&action=review

> Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:13
>  CLANG_ENABLE_OBJC_WEAK = YES;

Maybe I should also remove CLANG_ENABLE_OBJC_WEAK any time I am adding CLANG_ENABLE_OBJC_ARC since it’s redundant?

(In reply to Darin Adler from comment #2)
> Comment on attachment 342173 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=342173&action=review
> 
> > Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:13
> >  CLANG_ENABLE_OBJC_WEAK = YES;
> 
> Maybe I should also remove CLANG_ENABLE_OBJC_WEAK any time I am adding
> CLANG_ENABLE_OBJC_ARC since it’s redundant?

If we end up opting individual files out of ARC, either temporarily or permanently, we’d still want them to use Objective-C weak.

[Darin Adler]

Anyone willing to review? Everything’s working.

[Darin Adler]

Committed r232644: <https://trac.webkit.org/changeset/232644>

[Radar WebKit Bug Importer]

<rdar://problem/40953310>