Bug 186396 - [Cocoa] Minor ARC tidying of libwebrtc
Summary: [Cocoa] Minor ARC tidying of libwebrtc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-07 09:09 PDT by Darin Adler
Modified: 2018-06-08 15:31 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.03 KB, patch)
2018-06-07 09:10 PDT, Darin Adler 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2018-06-07 09:09:08 PDT 
[Cocoa] Minor ARC tidying of libwebrtc
Comment 1 Darin Adler 2018-06-07 09:10:36 PDT 
Created attachment 342173 [details]
Patch
Comment 2 Darin Adler 2018-06-07 09:35:47 PDT 
Comment on attachment 342173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342173&action=review

> Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:13
>  CLANG_ENABLE_OBJC_WEAK = YES;

Maybe I should also remove CLANG_ENABLE_OBJC_WEAK any time I am adding CLANG_ENABLE_OBJC_ARC since it’s redundant?
Comment 3 mitz 2018-06-07 09:51:44 PDT 
(In reply to Darin Adler from comment #2)
> Comment on attachment 342173 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=342173&action=review
> 
> > Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:13
> >  CLANG_ENABLE_OBJC_WEAK = YES;
> 
> Maybe I should also remove CLANG_ENABLE_OBJC_WEAK any time I am adding
> CLANG_ENABLE_OBJC_ARC since it’s redundant?

If we end up opting individual files out of ARC, either temporarily or permanently, we’d still want them to use Objective-C weak.
Comment 4 Darin Adler 2018-06-08 10:43:35 PDT 
Anyone willing to review? Everything’s working.
Comment 5 Darin Adler 2018-06-08 15:30:27 PDT 
Committed r232644: <https://trac.webkit.org/changeset/232644>
Comment 6 Radar WebKit Bug Importer 2018-06-08 15:31:19 PDT 
<rdar://problem/40953310>