Bug 186560 – [GTK][WPE] WebDriver: handle acceptInsecureCertificates capability

• Status: RESOLVED
• Resolution: FIXED
• Component: WebDriver

[Carlos Garcia Campos]

We currently process the capability, but it's not sent to the browser so it's actually ignored.

[Carlos Garcia Campos]

Created attachment 342526 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Carlos Garcia Campos]

Created attachment 342527 [details]
Patch

[EWS Watchlist]

Comment on attachment 342527 [details]
Patch

Attachment 342527 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8147166

New failing tests:
http/tests/security/canvas-remote-read-remote-video-redirect.html
http/tests/preload/onload_event.html

[EWS Watchlist]

Created attachment 342537 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Blaze Burg]

Comment on attachment 342527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342527&action=review

Everything else looks fine except the issue noted.

> Source/WebDriver/ChangeLog:9
> +        cabaility is sent.

Nit: capability

> Source/WebKit/UIProcess/Cocoa/AutomationClient.mm:89
> +    dispatch_async(dispatch_get_main_queue(), ^{

r- because this causes a UAF (which I only caught by applying manually and running tests ;-)). You need to do the following outside the block:

NSString *requestedSessionIdentifier = sessionIdentifier;

then use that NSString as the argument rather than applying the type conversion inside the block. The WTFString may no longer be around at that time.

[Carlos Garcia Campos]

Created attachment 342639 [details]
Updated patch

[Blaze Burg]

Comment on attachment 342639 [details]
Updated patch

r=me

[Carlos Garcia Campos]

Committed r232833: <https://trac.webkit.org/changeset/232833>

[Radar WebKit Bug Importer]

<rdar://problem/41117014>