Bug 186557 - [GTK][WPE] MiniBrowsers should be able to ignore TLS errors
Summary: [GTK][WPE] MiniBrowsers should be able to ignore TLS errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-12 01:44 PDT by Zan Dobersek
Modified: 2018-06-14 01:58 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.58 KB, patch)
2018-06-12 01:54 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (4.30 KB, patch)
2018-06-14 01:42 PDT, Zan Dobersek
cgarcia: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-06-12 01:44:06 PDT
[GTK] Ignore TLS errors when running WPT suite
Comment 1 Zan Dobersek 2018-06-12 01:54:05 PDT
Created attachment 342522 [details]
Patch
Comment 2 Carlos Garcia Campos 2018-06-12 02:36:39 PDT
Comment on attachment 342522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342522&action=review

> Tools/Scripts/webkitpy/webdriver_tests/webdriver_driver_gtk.py:42
> -        return ['--automation', '--javascript-can-open-windows-automatically=true', '--enable-xss-auditor=false']
> +        return ['--automation', '--javascript-can-open-windows-automatically=true',
> +            '--enable-xss-auditor=false', '--ignore-tls-errors=true']

I don't think we should do this here. We should implement and use acceptInsecureCerts capability instead. If we send this capability as part of the StartAutomationSession message, we can handle it internally without having to add an option to MiniBrowser and it will work with any browser. That's what I planned to do for the proxy capabilities.
Comment 3 Carlos Garcia Campos 2018-06-12 06:25:11 PDT
Bug #186560 is what I meant, but I'm not sure we will be able to use that approach in the end, because w3c tests don't allow to pass capabilities that are also added by the tests themselves. If we can't change the w3c tests behavior, then the patch attached here would be the only way, I think.
Comment 4 Zan Dobersek 2018-06-14 01:42:37 PDT
Created attachment 342728 [details]
Patch
Comment 5 Build Bot 2018-06-14 01:44:16 PDT
Attachment 342728 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/wpe/main.cpp:53:  Use nullptr instead of NULL.  [readability/null] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Carlos Garcia Campos 2018-06-14 01:51:52 PDT
Comment on attachment 342728 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342728&action=review

Thanks!

> Tools/MiniBrowser/wpe/main.cpp:53
> +    { "ignore-tls-errors", 0, 0, G_OPTION_ARG_NONE, &ignoreTLSErrors, "Ignore TLS errors", NULL },

Use nullptr here, WPE MiniBrowser is c++ not c.
Comment 7 Zan Dobersek 2018-06-14 01:57:06 PDT
Committed r232834: <https://trac.webkit.org/changeset/232834>
Comment 8 Radar WebKit Bug Importer 2018-06-14 01:58:18 PDT
<rdar://problem/41118909>