Bug 186335 – Add Accept-Encoding: identity to Range requests

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[Jake Archibald]

Spec change: https://github.com/whatwg/fetch/pull/751
Tests: https://github.com/web-platform-tests/wpt/pull/11291

Turns out a significant number of servers ignore Range headers unless "Accept-Encoding: identity" is set. This spec change applies that header to all requests with a Range header.

Safari already does this for media requests, although the header is applied before the service worker, when it should be afterwards.

Related issues:
https://bugs.webkit.org/show_bug.cgi?id=186050
https://bugs.webkit.org/show_bug.cgi?id=184447

[Radar WebKit Bug Importer]

<rdar://problem/40837190>

[youenn fablet]

Created attachment 342056 [details]
Patch

[Eric Carlson]

Comment on attachment 342056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342056&action=review

> Source/WebCore/loader/cache/CachedResourceRequest.cpp:214
> +    // FIXME: We should ask the media engine to not set this header.

Please file a Radar and include the number here.

[youenn fablet]

Created attachment 342113 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 342113 [details]
Patch for landing

Clearing flags on attachment: 342113

Committed r232571: <https://trac.webkit.org/changeset/232571>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.