Bug 186103 - [iOS] -[WKFullScreenViewController viewWillAppear:] should call [super viewWillAppear:]
Summary: [iOS] -[WKFullScreenViewController viewWillAppear:] should call [super viewWi...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Keywords: InRadar
Depends on: 186067
  Show dependency treegraph
Reported: 2018-05-30 11:02 PDT by David Kilzer (:ddkilzer)
Modified: 2018-05-30 13:41 PDT (History)
6 users (show)

See Also:

Patch v1 (2.25 KB, patch)
2018-05-30 11:10 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch v2 (2.00 KB, patch)
2018-05-30 11:21 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2018-05-30 11:02:58 PDT
Fix static analyzer warnings in WKFullScreenViewController.mm:

Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:70:13: warning: Called C++ object pointer is null
Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:306:1: warning: The 'viewWillAppear:' instance method in UIViewController subclass 'WKFullScreenViewController' is missing a [super viewWillAppear:] call
2 warnings generated.
Comment 1 Radar WebKit Bug Importer 2018-05-30 11:03:26 PDT
Comment 2 David Kilzer (:ddkilzer) 2018-05-30 11:10:27 PDT
Created attachment 341584 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2018-05-30 11:18:33 PDT
Jer fixed the first issue in:

Bug 186067: Fix a few issues in WKFullScreenViewController

Updating this just to fix the -viewWillAppear: issue.
Comment 4 David Kilzer (:ddkilzer) 2018-05-30 11:21:28 PDT
Created attachment 341585 [details]
Patch v2
Comment 5 WebKit Commit Bot 2018-05-30 13:41:12 PDT
Comment on attachment 341585 [details]
Patch v2

Clearing flags on attachment: 341585

Committed r232308: <https://trac.webkit.org/changeset/232308>
Comment 6 WebKit Commit Bot 2018-05-30 13:41:14 PDT
All reviewed patches have been landed.  Closing bug.