Bug 186103 – [iOS] -[WKFullScreenViewController viewWillAppear:] should call [super viewWillAppear:]

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[David Kilzer (:ddkilzer)]

Fix static analyzer warnings in WKFullScreenViewController.mm:

Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:70:13: warning: Called C++ object pointer is null
            interface->playbackSessionModel()->removeClient(*this);
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:306:1: warning: The 'viewWillAppear:' instance method in UIViewController subclass 'WKFullScreenViewController' is missing a [super viewWillAppear:] call
}
^
2 warnings generated.

[Radar WebKit Bug Importer]

<rdar://problem/40655695>

[David Kilzer (:ddkilzer)]

Created attachment 341584 [details]
Patch v1

[David Kilzer (:ddkilzer)]

Jer fixed the first issue in:

Bug 186067: Fix a few issues in WKFullScreenViewController
<https://bugs.webkit.org/show_bug.cgi?id=186067>
<https://trac.webkit.org/changeset/232299>

Updating this just to fix the -viewWillAppear: issue.

[David Kilzer (:ddkilzer)]

Created attachment 341585 [details]
Patch v2

[WebKit Commit Bot]

Comment on attachment 341585 [details]
Patch v2

Clearing flags on attachment: 341585

Committed r232308: <https://trac.webkit.org/changeset/232308>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.