Bug 186067 - Fix a few issues in WKFullScreenViewController
Summary: Fix a few issues in WKFullScreenViewController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on: 186063
Blocks: 186103
  Show dependency tree / graph
 
Reported: 2018-05-29 15:20 PDT by Jer Noble
Modified: 2018-05-30 11:18 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.02 KB, patch)
2018-05-29 15:23 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-05-29 15:20:59 PDT 
Fix a few issues in WKFullScreenViewController
Comment 1 Radar WebKit Bug Importer 2018-05-29 15:21:35 PDT 
<rdar://problem/40630944>
Comment 2 Jer Noble 2018-05-29 15:23:04 PDT 
Created attachment 341527 [details]
Patch
Comment 3 Darin Adler 2018-05-29 22:09:51 PDT 
Comment on attachment 341527 [details]
Patch

No test coverage for either of these mistakes?
Comment 4 Jer Noble 2018-05-30 10:07:51 PDT 
The "interface -> m_interface" bug was found during development of bug #186063, and this fix will be tested by the test that patch introduces.
Comment 5 WebKit Commit Bot 2018-05-30 10:46:55 PDT 
Comment on attachment 341527 [details]
Patch

Clearing flags on attachment: 341527

Committed r232299: <https://trac.webkit.org/changeset/232299>
Comment 6 WebKit Commit Bot 2018-05-30 10:46:56 PDT 
All reviewed patches have been landed.  Closing bug.