Bug 186093 - For <video> element, use video fullscreen instead of element fullscreen.
Summary: For <video> element, use video fullscreen instead of element fullscreen.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-30 07:30 PDT by Jeremy Jones
Modified: 2018-07-06 18:31 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.96 KB, patch)
2018-05-30 07:33 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Patch (3.18 KB, patch)
2018-05-30 15:06 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Patch (3.18 KB, patch)
2018-06-28 11:26 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Patch (3.20 KB, patch)
2018-06-28 11:46 PDT, Jeremy Jones
jer.noble: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews204 for win-future (12.87 MB, application/zip)
2018-06-28 13:42 PDT, EWS Watchlist
no flags Details
Patch for landing. (2.92 KB, patch)
2018-07-06 16:00 PDT, Jeremy Jones
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews205 for win-future (12.88 MB, application/zip)
2018-07-06 18:31 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2018-05-30 07:30:18 PDT
Enable video controls when in element fullscreen.
Comment 1 Jeremy Jones 2018-05-30 07:30:59 PDT
rdar://problem/40144751
Comment 2 Jeremy Jones 2018-05-30 07:33:21 PDT
Created attachment 341570 [details]
Patch
Comment 3 Jeremy Jones 2018-05-30 15:06:16 PDT
Created attachment 341606 [details]
Patch
Comment 4 Antoine Quint 2018-05-31 00:21:24 PDT
Comment on attachment 341606 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341606&action=review

> Source/WebCore/html/HTMLVideoElement.cpp:198
> +    document().addConsoleMessage(MessageSource::Media, MessageLevel::Debug, ASCIILiteral("For video element use webkitSetPresentationMode('Fullscreen') instead of webkitRequestFullscreen()."));

I'm not sure this is the right message. Is setPresentationMode on a standard track somewhere? If it's not, it would be ill-advised to recommend its use vs. a method that is on the standards track, albeit with a webkit prefix. Also, <video> instead of "video" would be preferable.
Comment 5 Jeremy Jones 2018-06-28 11:26:05 PDT
Created attachment 343820 [details]
Patch
Comment 6 Jeremy Jones 2018-06-28 11:26:34 PDT
(In reply to Antoine Quint from comment #4)
> Comment on attachment 341606 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=341606&action=review
> 
> > Source/WebCore/html/HTMLVideoElement.cpp:198
> > +    document().addConsoleMessage(MessageSource::Media, MessageLevel::Debug, ASCIILiteral("For video element use webkitSetPresentationMode('Fullscreen') instead of webkitRequestFullscreen()."));
> 
> I'm not sure this is the right message. Is setPresentationMode on a standard
> track somewhere? If it's not, it would be ill-advised to recommend its use
> vs. a method that is on the standards track, albeit with a webkit prefix.
> Also, <video> instead of "video" would be preferable.

changed "video" to "<video>"
Comment 7 Jeremy Jones 2018-06-28 11:46:34 PDT
Created attachment 343823 [details]
Patch
Comment 8 EWS Watchlist 2018-06-28 13:42:37 PDT
Comment on attachment 343823 [details]
Patch

Attachment 343823 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8372693

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html
Comment 9 EWS Watchlist 2018-06-28 13:42:48 PDT
Created attachment 343843 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 10 Jer Noble 2018-06-28 14:17:23 PDT
Comment on attachment 343823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343823&action=review

> Source/WebCore/html/HTMLVideoElement.cpp:198
> +    document().addConsoleMessage(MessageSource::Media, MessageLevel::Debug, "For <video> element use webkitSetPresentationMode('Fullscreen') instead of webkitRequestFullscreen()."_s);

Nit -> "Fullscreen" should be "fullscreen".

We should probably make this non-imperative. Like, "For <video> element use, webkitRequestFullscreen() will use webkitSetPresentationMode('Fullscreen')".
Comment 11 Jeremy Jones 2018-07-06 16:00:22 PDT
Created attachment 344473 [details]
Patch for landing.
Comment 12 WebKit Commit Bot 2018-07-06 16:47:23 PDT
The commit-queue encountered the following flaky tests while processing attachment 344473 [details]:

media/media-fullscreen-loop-inline.html bug 187424 (author: jeremyj-wk@apple.com)
The commit-queue is continuing to process your patch.
Comment 13 WebKit Commit Bot 2018-07-06 16:47:34 PDT
The commit-queue encountered the following flaky tests while processing attachment 344473 [details]:

media/media-fullscreen-return-to-inline.html bug 187387 (authors: graouts@apple.com, mcatanzaro@igalia.com, and ryanhaddad@apple.com)
The commit-queue is continuing to process your patch.
Comment 14 WebKit Commit Bot 2018-07-06 17:15:33 PDT
Comment on attachment 344473 [details]
Patch for landing.

Clearing flags on attachment: 344473

Committed r233605: <https://trac.webkit.org/changeset/233605>
Comment 15 EWS Watchlist 2018-07-06 18:30:58 PDT
Comment on attachment 344473 [details]
Patch for landing.

Attachment 344473 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8462274

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
Comment 16 EWS Watchlist 2018-07-06 18:31:10 PDT
Created attachment 344497 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit