Enable video controls when in element fullscreen.
rdar://problem/40144751
Created attachment 341570 [details] Patch
Created attachment 341606 [details] Patch
Comment on attachment 341606 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341606&action=review > Source/WebCore/html/HTMLVideoElement.cpp:198 > + document().addConsoleMessage(MessageSource::Media, MessageLevel::Debug, ASCIILiteral("For video element use webkitSetPresentationMode('Fullscreen') instead of webkitRequestFullscreen().")); I'm not sure this is the right message. Is setPresentationMode on a standard track somewhere? If it's not, it would be ill-advised to recommend its use vs. a method that is on the standards track, albeit with a webkit prefix. Also, <video> instead of "video" would be preferable.
Created attachment 343820 [details] Patch
(In reply to Antoine Quint from comment #4) > Comment on attachment 341606 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=341606&action=review > > > Source/WebCore/html/HTMLVideoElement.cpp:198 > > + document().addConsoleMessage(MessageSource::Media, MessageLevel::Debug, ASCIILiteral("For video element use webkitSetPresentationMode('Fullscreen') instead of webkitRequestFullscreen().")); > > I'm not sure this is the right message. Is setPresentationMode on a standard > track somewhere? If it's not, it would be ill-advised to recommend its use > vs. a method that is on the standards track, albeit with a webkit prefix. > Also, <video> instead of "video" would be preferable. changed "video" to "<video>"
Created attachment 343823 [details] Patch
Comment on attachment 343823 [details] Patch Attachment 343823 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8372693 New failing tests: http/tests/security/video-poster-cross-origin-crash2.html
Created attachment 343843 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 343823 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343823&action=review > Source/WebCore/html/HTMLVideoElement.cpp:198 > + document().addConsoleMessage(MessageSource::Media, MessageLevel::Debug, "For <video> element use webkitSetPresentationMode('Fullscreen') instead of webkitRequestFullscreen()."_s); Nit -> "Fullscreen" should be "fullscreen". We should probably make this non-imperative. Like, "For <video> element use, webkitRequestFullscreen() will use webkitSetPresentationMode('Fullscreen')".
Created attachment 344473 [details] Patch for landing.
The commit-queue encountered the following flaky tests while processing attachment 344473 [details]: media/media-fullscreen-loop-inline.html bug 187424 (author: jeremyj-wk@apple.com) The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 344473 [details]: media/media-fullscreen-return-to-inline.html bug 187387 (authors: graouts@apple.com, mcatanzaro@igalia.com, and ryanhaddad@apple.com) The commit-queue is continuing to process your patch.
Comment on attachment 344473 [details] Patch for landing. Clearing flags on attachment: 344473 Committed r233605: <https://trac.webkit.org/changeset/233605>
Comment on attachment 344473 [details] Patch for landing. Attachment 344473 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8462274 New failing tests: http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
Created attachment 344497 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit