Bug 186063 - Media elements outside fullscreen should not be considered main content.
Summary: Media elements outside fullscreen should not be considered main content.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks: 186067
  Show dependency treegraph
 
Reported: 2018-05-29 15:07 PDT by Jer Noble
Modified: 2018-05-30 11:00 PDT (History)
4 users (show)

See Also:


Attachments
Patch (15.61 KB, patch)
2018-05-29 15:11 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (15.65 KB, patch)
2018-05-29 15:29 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-05-29 15:07:24 PDT
Media elements outside fullscreen should not be considered main content.
Comment 1 Radar WebKit Bug Importer 2018-05-29 15:08:11 PDT
<rdar://problem/40630437>
Comment 2 Jer Noble 2018-05-29 15:11:15 PDT
Created attachment 341523 [details]
Patch
Comment 3 Jer Noble 2018-05-29 15:29:35 PDT
Created attachment 341528 [details]
Patch
Comment 4 Eric Carlson 2018-05-30 10:11:43 PDT
Comment on attachment 341528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341528&action=review

> Source/WebCore/testing/Internals.h:45
> +#if ENABLE(VIDEO)
> +#include "MediaElementSession.h"
> +#endif

Nit: you can forward declare the enum instead of including the header here
Comment 5 WebKit Commit Bot 2018-05-30 11:00:29 PDT
Comment on attachment 341528 [details]
Patch

Clearing flags on attachment: 341528

Committed r232300: <https://trac.webkit.org/changeset/232300>
Comment 6 WebKit Commit Bot 2018-05-30 11:00:31 PDT
All reviewed patches have been landed.  Closing bug.