Bug 185867 - [GTK] WebDriver: Network process crash when running imported/w3c/webdriver/tests/delete_cookie/delete.py::test_unknown_cookie
Summary: [GTK] WebDriver: Network process crash when running imported/w3c/webdriver/te...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2018-05-22 06:25 PDT by Carlos Garcia Campos
Modified: 2018-05-22 08:10 PDT (History)
6 users (show)

See Also:


Attachments
Patch (4.03 KB, patch)
2018-05-22 06:28 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-05-22 06:25:37 PDT
webkitpy.webdriver_tests.webdriver_w3c_executor: [DEBUG] (WebKitWebDriver:21620): (process:21647): libsoup-CRITICAL **: 15:18:04.117: soup_cookie_jar_get_cookie_list: assertion 'uri != NULL' failed
webkitpy.webdriver_tests.webdriver_w3c_executor: [DEBUG] (WebKitWebDriver:21620): RemoteInspectorServer failed to send DBus message: The connection is closed

We need to null check the value returned by URL::createSoupURI() before passing it to soup.
Comment 1 Carlos Garcia Campos 2018-05-22 06:28:00 PDT
Created attachment 340979 [details]
Patch
Comment 2 Carlos Garcia Campos 2018-05-22 08:10:09 PDT
Committed r232066: <https://trac.webkit.org/changeset/232066>