Bug 185866 - [GTK] WebDriver: implement AutomationSessionClient::didDisconnectFromRemote
Summary: [GTK] WebDriver: implement AutomationSessionClient::didDisconnectFromRemote
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2018-05-22 05:44 PDT by Carlos Garcia Campos
Modified: 2018-05-23 08:25 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.42 KB, patch)
2018-05-22 06:03 PDT, Carlos Garcia Campos 		bburg: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews201 for win-future (12.74 MB, application/zip)
2018-05-22 07:49 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-05-22 05:44:12 PDT 
To handle the case of the session being closed by the browser, for example in case of a network process crash. This is currently causing WebDriver tests to timeout in the bot.
Comment 1 Carlos Garcia Campos 2018-05-22 06:03:52 PDT 
Created attachment 340978 [details]
Patch
Comment 2 EWS Watchlist 2018-05-22 06:04:39 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 EWS Watchlist 2018-05-22 07:49:03 PDT 
Comment on attachment 340978 [details]
Patch

Attachment 340978 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7765003

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
Comment 4 EWS Watchlist 2018-05-22 07:49:15 PDT 
Created attachment 340982 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 BJ Burg 2018-05-22 13:13:37 PDT 
Comment on attachment 340978 [details]
Patch

r=me, though you may want to consult a GTK reviewer as well.
Comment 6 Michael Catanzaro 2018-05-23 07:59:32 PDT 
Comment on attachment 340978 [details]
Patch

GTK changes are fine.
Comment 7 Carlos Garcia Campos 2018-05-23 08:25:11 PDT 
Committed r232111: <https://trac.webkit.org/changeset/232111>