Re-sync & unskip web-platform-tests/workers/semantics/structured-clone/ after https://github.com/w3c/web-platform-tests/issues/10799.
Created attachment 340735 [details] Patch
Comment on attachment 340735 [details] Patch Attachment 340735 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7725778 New failing tests: fast/storage/serialized-script-value.html imported/w3c/web-platform-tests/IndexedDB/keypath-special-identifiers.htm
Created attachment 340741 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 340735 [details] Patch Attachment 340735 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7725852 New failing tests: fast/storage/serialized-script-value.html imported/w3c/web-platform-tests/IndexedDB/keypath-special-identifiers.htm
Created attachment 340744 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 340747 [details] Patch
Comment on attachment 340747 [details] Patch Attachment 340747 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7728784 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
Created attachment 340770 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
ping review?
Comment on attachment 340747 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340747&action=review > Source/WebCore/fileapi/File.h:87 > + const std::optional<double>& lastModifiedOverride() const { return m_overrideLastModifiedDate; } Is there a reason to pass a std::optional<double> in deserialize but here return a const& ? > Source/WebCore/fileapi/File.h:115 > + std::optional<double> m_overrideLastModifiedDate; I guess this is mandated by File IDL? > LayoutTests/imported/w3c/web-platform-tests/workers/semantics/structured-clone/shared-expected.txt:1 > +CONSOLE MESSAGE: line 19: ReferenceError: Can't find variable: SharedWorker Might want to skip this one.
Comment on attachment 340747 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340747&action=review >> Source/WebCore/fileapi/File.h:115 >> + std::optional<double> m_overrideLastModifiedDate; > > I guess this is mandated by File IDL? Actually, the IDL is using "long long" which maps to int64_t. I'll update my patch to use this consistently internally.
Comment on attachment 340747 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340747&action=review >> Source/WebCore/fileapi/File.h:87 >> + const std::optional<double>& lastModifiedOverride() const { return m_overrideLastModifiedDate; } > > Is there a reason to pass a std::optional<double> in deserialize but here return a const& ? I'll use const & consistently.
Created attachment 340886 [details] Patch
Comment on attachment 340886 [details] Patch Rejecting attachment 340886 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 340886, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/7756691
Created attachment 340889 [details] Patch
Comment on attachment 340889 [details] Patch Rejecting attachment 340889 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 340889, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Youen Fablet found in /Volumes/Data/EWS/WebKit/LayoutTests/imported/w3c/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/LayoutTests/imported/w3c/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/7757009
Created attachment 340892 [details] Patch
Comment on attachment 340892 [details] Patch Clearing flags on attachment: 340892 Committed r232030: <https://trac.webkit.org/changeset/232030>
All reviewed patches have been landed. Closing bug.
<rdar://problem/40430827>
Re-opened since this is blocked by bug 185850
Created attachment 340939 [details] Patch
Comment on attachment 340939 [details] Patch Clearing flags on attachment: 340939 Committed r232043: <https://trac.webkit.org/changeset/232043>