RESOLVED FIXED 185586
Disable pointer poisoning 
https://bugs.webkit.org/show_bug.cgi?id=185586
Summary Disable pointer poisoning
Filip Pizlo
Reported 2018-05-13 11:02:21 PDT
It seems to possibly be a small speed-up. I want to see if the bots agree.
Attachments
the patch (1.30 KB, patch)
2018-05-13 11:03 PDT, Filip Pizlo 		ysuzuki: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2018-05-13 11:03:24 PDT
Created attachment 340268 [details] the patch
Yusuke Suzuki
Comment 2 2018-05-13 11:06:04 PDT
Comment on attachment 340268 [details] the patch r=me. BTW, do you plan to remove this functionality? I have a patch for Windows 64bit poisoning right now (https://bugs.webkit.org/show_bug.cgi?id=185421). If it will be removed soon, I'll make that patch WONTFIX.
Filip Pizlo
Comment 3 2018-05-13 11:56:35 PDT
(In reply to Yusuke Suzuki from comment #2) > Comment on attachment 340268 [details] > the patch > > r=me. BTW, do you plan to remove this functionality? I have a patch for > Windows 64bit poisoning right now > (https://bugs.webkit.org/show_bug.cgi?id=185421). If it will be removed > soon, I'll make that patch WONTFIX. I think that if it's a confirmed speed-up then we will remove it.
Filip Pizlo
Comment 4 2018-05-13 11:57:21 PDT
Landed in https://trac.webkit.org/changeset/231743/webkit
Radar WebKit Bug Importer
Comment 5 2018-05-13 11:58:18 PDT
<rdar://problem/40202974>
Ryan Haddad
Comment 6 2018-05-14 15:39:13 PDT
I suppose this may be expected, but this caused some API tests to timeout: Timeout TestWTF.WTF_PoisonedUniquePtrForTriviallyDestructibleArrays.Assignment TestWTF.WTF_PoisonedUniquePtrForNonTriviallyDestructibleArrays.Basic TestWTF.WTF_PoisonedUniquePtr.Assignment TestWTF.WTF_PoisonedUniquePtrForNonTriviallyDestructibleArrays.Swap TestWTF.WTF_PoisonedUniquePtrForNonTriviallyDestructibleArrays.ReturnValue TestWTF.WTF_Poisoned.Assignment TestWTF.WTF_PoisonedUniquePtr.Swap TestWTF.WTF_Poisoned.ReturnValue TestWTF.WTF_PoisonedUniquePtrForTriviallyDestructibleArrays.ReturnValue TestWTF.WTF_PoisonedUniquePtrForTriviallyDestructibleArrays.Basic TestWTF.WTF_PoisonedUniquePtr.Basic TestWTF.WTF_Poisoned.Swap TestWTF.WTF_Poisoned.Basic TestWTF.WTF_PoisonedUniquePtr.ReturnValue TestWTF.WTF_PoisonedUniquePtrForNonTriviallyDestructibleArrays.Assignment TestWTF.WTF_PoisonedUniquePtrForTriviallyDestructibleArrays.Swap https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/4487
Ryan Haddad
Comment 7 2018-05-14 16:16:35 PDT
Disabled API tests in https://trac.webkit.org/r231774
Note You need to log in before you can comment on or make changes to this bug.