Bug 185421 - [Win] Enable poisoning in 64bit Windows
Summary: [Win] Enable poisoning in 64bit Windows
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-08 07:08 PDT by Yusuke Suzuki
Modified: 2020-05-30 20:17 PDT (History)
10 users (show)

See Also:


Attachments
WIP (5.68 KB, patch)
2018-05-08 07:09 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (11.53 KB, patch)
2018-05-09 06:02 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (12.16 KB, patch)
2018-05-09 10:58 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (12.16 KB, patch)
2018-05-09 11:09 PDT, Yusuke Suzuki
mjs: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-05-08 07:08:55 PDT
[Win] Enable poisoning in 64bit Windows
Comment 1 Yusuke Suzuki 2018-05-08 07:09:11 PDT
Created attachment 339815 [details]
WIP
Comment 2 Yusuke Suzuki 2018-05-09 06:02:00 PDT
Created attachment 339959 [details]
Patch
Comment 3 Yusuke Suzuki 2018-05-09 10:36:02 PDT
Comment on attachment 339959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339959&action=review

> Source/JavaScriptCore/offlineasm/x86.rb:67
> +# rcx => t5, a0

This is not correct. While t5 is actually rcx in baseline JIT side, this does not meet the requirement in LLInt.
Comment 4 Yusuke Suzuki 2018-05-09 10:58:20 PDT
Created attachment 339983 [details]
Patch
Comment 5 Yusuke Suzuki 2018-05-09 11:04:46 PDT
Comment on attachment 339983 [details]
Patch

Not working well. Fixing.
Comment 6 Yusuke Suzuki 2018-05-09 11:09:58 PDT
Created attachment 339986 [details]
Patch
Comment 7 Yusuke Suzuki 2018-05-09 11:13:38 PDT
OK, it is working :)
Comment 8 Maciej Stachowiak 2020-05-30 20:17:31 PDT
Comment on attachment 339986 [details]
Patch

Poisoning has been removed.