Bug 185531 – REGRESSION (async policy delegate): Revoking an object URL immediately after triggering download breaks file download

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Chris Dumez]

Revoking an object URL immediately after triggering download breaks file download since asynchronous policy delegates.

[Chris Dumez]

<rdar://problem/39909589>

[Chris Dumez]

Created attachment 340141 [details]
Patch

[EWS Watchlist]

Attachment 340141 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/BlobRegistry.cpp:54:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/BlobRegistry.cpp:60:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/BlobRegistry.cpp:61:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Comment on attachment 340141 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340141&action=review

> Source/WebCore/platform/network/BlobRegistry.cpp:60
> +    , m_counter([this](RefCounterEvent) { if (!m_counter.value()) lifeTimeExtensionExpired(); })

Does LifetimeExtension need to be an object with a special kind of counter, or can the LifetimeExtension class just use RefCounted and a destructor? The idea that holding a LifetimeExtension is not enough, and you also need to hold a token to its internal counter, is a bit surprising -- and it seems that the counter doesn't do anything except count down to zero and then delete the object.

[Chris Dumez]

Created attachment 340148 [details]
Patch

[Chris Dumez]

Created attachment 340150 [details]
Patch

[EWS Watchlist]

Comment on attachment 340150 [details]
Patch

Attachment 340150 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7645285

New failing tests:
fast/dom/HTMLAnchorElement/anchor-file-blob-download-then-revoke.html

[EWS Watchlist]

Created attachment 340156 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[Chris Dumez]

Created attachment 340199 [details]
Patch

[Geoffrey Garen]

Comment on attachment 340199 [details]
Patch

r=me

[Geoffrey Garen]

This is nicer!

[WebKit Commit Bot]

Comment on attachment 340199 [details]
Patch

Clearing flags on attachment: 340199

Committed r231714: <https://trac.webkit.org/changeset/231714>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.