Bug 185464 - [MIPS] Use mfhc1 and mthc1 to fix assembler error
Summary: [MIPS] Use mfhc1 and mthc1 to fix assembler error
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2018-05-08 22:23 PDT by Dominik Inführ
Modified: 2018-05-24 06:17 PDT (History)
13 users (show)

See Also:

Patch (1.96 KB, patch)
2018-05-08 22:27 PDT, Dominik Inführ
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Inführ 2018-05-08 22:23:16 PDT
[MIPS] Use mfhc1 and mthc1 to fix assembler error
Comment 1 Dominik Inführ 2018-05-08 22:27:19 PDT
Created attachment 339930 [details]
Comment 2 WebKit Commit Bot 2018-05-08 23:29:10 PDT
Comment on attachment 339930 [details]

Rejecting attachment 339930 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 339930, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ing rebase:
:040000 040000 4dd5f054ca0fd1facf03faceff772d7f02351f71 5d2ee099462e6ac44ce4a6829a77d3db3d944b92 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.

Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/7620528
Comment 3 WebKit Commit Bot 2018-05-09 01:53:22 PDT
Comment on attachment 339930 [details]

Clearing flags on attachment: 339930

Committed r231552: <https://trac.webkit.org/changeset/231552>
Comment 4 WebKit Commit Bot 2018-05-09 01:53:23 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-05-09 01:54:18 PDT
Comment 6 Loïc Yhuel 2018-05-23 08:40:38 PDT
This change breaks the build on MIPS32r1 (which doesn't support mfhc1 and mthc1).

I assume the assembler error was on a -mfpxx or -mfp64 target, which runs (or should be able to run for -mfpxx) with FR=1 (f0..f31 are independent 64 bit registers).

The original code is fine with -mfp32, running with FR=0 (f0..f31 are 32 bit registers, instructions operating on double use two even+odd register), which is the only mode supported on MIPS32r1.

Comment 7 Dominik Inführ 2018-05-24 06:17:35 PDT
I've tried to fix that in https://bugs.webkit.org/show_bug.cgi?id=185944. What do you think?