Bug 185944 - [MIPS] Fix build on MIPS32r1
Summary: [MIPS] Fix build on MIPS32r1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-24 06:10 PDT by Dominik Inführ
Modified: 2018-05-30 07:14 PDT (History)
18 users (show)

See Also:

Attachments
Patch (3.42 KB, patch)
2018-05-24 06:15 PDT, Dominik Inführ 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Inführ 2018-05-24 06:10:21 PDT 
[MIPS] Fix build on MIPS32r1
Comment 1 Dominik Inführ 2018-05-24 06:15:24 PDT 
Created attachment 341185 [details]
Patch
Comment 2 Loïc Yhuel 2018-05-24 08:40:06 PDT 
This looks ok, and builds fine.

Here are the different cases I can think of :
 - -march=mips32 -mfp32 : mtc1/mfc1, OK
 - -march=mips32 -mfpxx (so __mips_isa_rev == 1, __mips_fpr == 0) : "as" would fail with "Error: float register should be even, was xx" (the only way would be to an intermediate memory transfer). Nothing changes here, so I think no one uses this configuration so it's fine if WebKit doesn't support it.
 - -march=mips32r2 -mfp32 : mfhc1 and mthc1 are used even if not necessary, but this isn't an issue
 - -march=mips32r2 -mfpxx : mfhc1 and mthc1, OK
 - -mfp64 : gcc already ensures mfhc1 and mthc1 are available
Comment 3 Olivier Blin 2018-05-25 07:41:57 PDT 
I confirm it builds fine on a MIPS32r1 target, and jsc runs correctly too.
Comment 4 Yusuke Suzuki 2018-05-30 06:46:31 PDT 
Comment on attachment 341185 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2018-05-30 07:13:27 PDT 
Comment on attachment 341185 [details]
Patch

Clearing flags on attachment: 341185

Committed r232290: <https://trac.webkit.org/changeset/232290>
Comment 6 WebKit Commit Bot 2018-05-30 07:13:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-05-30 07:14:24 PDT 
<rdar://problem/40649432>