Bug 185061 - REGRESSION (r231039): RunUnitTests step reports disabled tests as failures
Summary: REGRESSION (r231039): RunUnitTests step reports disabled tests as failures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Haddad
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-26 17:34 PDT by Ryan Haddad
Modified: 2018-04-26 18:26 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.75 KB, patch)
2018-04-26 17:43 PDT, Ryan Haddad 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2018-04-26 17:34:44 PDT 
After https://trac.webkit.org/changeset/231039, the RunUnitTests step reports 13 test failures even though none actually failed. This is because it is comparing the total number of tests to the number that passed without taking into account those that are disabled.

See:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/builds/4950
Comment 1 Ryan Haddad 2018-04-26 17:43:44 PDT 
Created attachment 338942 [details]
Patch
Comment 2 Ryan Haddad 2018-04-26 17:46:51 PDT 
Comment on attachment 338942 [details]
Patch

Thanks, Aakash!
Comment 3 WebKit Commit Bot 2018-04-26 18:25:16 PDT 
Comment on attachment 338942 [details]
Patch

Clearing flags on attachment: 338942

Committed r231083: <https://trac.webkit.org/changeset/231083>
Comment 4 WebKit Commit Bot 2018-04-26 18:25:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-04-26 18:26:19 PDT 
<rdar://problem/39778914>