Bug 184982 - REGRESSION (r230998): Bot watcher's dashboard doesn't display number of API test failures
Summary: REGRESSION (r230998): Bot watcher's dashboard doesn't display number of API t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-25 11:10 PDT by Ryan Haddad
Modified: 2018-04-26 17:34 PDT (History)
7 users (show)

See Also:


Attachments
Patch (13.36 KB, patch)
2018-04-25 16:36 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (13.37 KB, patch)
2018-04-25 16:46 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2018-04-25 11:10:53 PDT
After https://trac.webkit.org/changeset/230998/webkit, the bot watcher's dashboard no longer displays the number of API tests that failed, displaying "api test failed" instead of "1 api test failure"

The status for the run-api-tests step no longer displays the number of failures, as seen below

Test run with API test failure before r230998: "1 unit test failed or timed out "
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/9731

Test run with API test failure after r230998: "run-api-tests"
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/9732
Comment 1 Ryan Haddad 2018-04-25 11:45:40 PDT
Looks like we need to update the regex in Tools/BuildSlaveSupport/build.webkit.org-config/steps.py for RunUnitTests.
Comment 2 Jonathan Bedard 2018-04-25 16:36:10 PDT
Created attachment 338822 [details]
Patch
Comment 3 Aakash Jain 2018-04-25 16:40:26 PDT
rs=me
Comment 4 Jonathan Bedard 2018-04-25 16:46:01 PDT
Created attachment 338824 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-04-25 19:11:04 PDT
Comment on attachment 338824 [details]
Patch for landing

Clearing flags on attachment: 338824

Committed r231039: <https://trac.webkit.org/changeset/231039>
Comment 6 WebKit Commit Bot 2018-04-25 19:11:05 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-04-25 19:13:10 PDT
<rdar://problem/39744413>