HTML String load cannot be prevented by responding 'Cancel' asynchronously in decidePolicyForNavigationAction.
<rdar://problem/39145306>
Created attachment 338483 [details] Patch
Created attachment 338493 [details] Patch
Comment on attachment 338493 [details] Patch Attachment 338493 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7390883 New failing tests: fast/events/beforeunload-alert-user-interaction2.html webarchive/loading/javascript-url-iframe-crash.html fast/events/beforeunload-alert.html
Created attachment 338508 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Created attachment 338518 [details] Patch
Comment on attachment 338518 [details] Patch Attachment 338518 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7393468 New failing tests: webarchive/loading/javascript-url-iframe-crash.html
Created attachment 338521 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 338518 [details] Patch Attachment 338518 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7393675 New failing tests: webarchive/loading/javascript-url-iframe-crash.html
Created attachment 338523 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 338589 [details] Patch
Comment on attachment 338589 [details] Patch Clearing flags on attachment: 338589 Committed r230919: <https://trac.webkit.org/changeset/230919>
All reviewed patches have been landed. Closing bug.
This change appears to have caused the flaky failures seen with the fast/events/beforeunload tests seen here: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r230928%20(4164)/results.html
(In reply to Ryan Haddad from comment #14) > This change appears to have caused the flaky failures seen with the > fast/events/beforeunload tests seen here: > https://build.webkit.org/results/ > Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r230928%20(4164)/results.html Ok, looking now. The tests probably need updating.
(In reply to Chris Dumez from comment #15) > (In reply to Ryan Haddad from comment #14) > > This change appears to have caused the flaky failures seen with the > > fast/events/beforeunload tests seen here: > > https://build.webkit.org/results/ > > Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r230928%20(4164)/results.html > > Ok, looking now. The tests probably need updating. As I thought. I will update the tests shortly.
(In reply to Chris Dumez from comment #16) > (In reply to Chris Dumez from comment #15) > > (In reply to Ryan Haddad from comment #14) > > > This change appears to have caused the flaky failures seen with the > > > fast/events/beforeunload tests seen here: > > > https://build.webkit.org/results/ > > > Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r230928%20(4164)/results.html > > > > Ok, looking now. The tests probably need updating. > > As I thought. I will update the tests shortly. https://trac.webkit.org/r230939