184209 – REGRESSION (r229133): decidePolicyForNavigationAction not called for loading an HTML string

RESOLVED FIXED 184209

REGRESSION (r229133): decidePolicyForNavigationAction not called for loading an HTML string

https://bugs.webkit.org/show_bug.cgi?id=184209

Summary REGRESSION (r229133): decidePolicyForNavigationAction not called for loading ...

mitz

Reported 2018-03-31 00:24:08 PDT

Created attachment 336920 [details] Test program In TOT (r230119), the policy delegate method -webView:decidePolicyForNavigationAction:decisionHandler: isn’t called for a navigation initiated with -loadHTMLString:baseURL:. In the shipping WebKit as of macOS 10.13.4, it does get called. To reproduce: build and run the attached TestDecidePolicyForNavigationAction. Note that when running with TOT webkit, the initial content loads without the “Decide Policy For Navigation Action” sheet being presented. When running with built-in WebKit in macOS 10.13.4, the sheet does appear.

Attachments
Test program (26.38 KB, application/zip) 2018-03-31 00:24 PDT, mitz	no flags	Details
Test program (62.11 KB, application/zip) 2018-03-31 00:27 PDT, mitz	no flags	Details
Patch (3.92 KB, patch) 2018-04-18 10:40 PDT, Chris Dumez	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.67 MB, application/zip) 2018-04-18 11:50 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (8.75 MB, application/zip) 2018-04-18 12:14 PDT, EWS Watchlist	no flags	Details
WIP patch (5.94 KB, patch) 2018-04-18 15:21 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (20.19 MB, application/zip) 2018-04-18 16:24 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (58.67 MB, application/zip) 2018-04-18 16:28 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-sierra (20.69 MB, application/zip) 2018-04-18 16:57 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (48.17 MB, application/zip) 2018-04-18 17:04 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews202 for win-future (13.58 MB, application/zip) 2018-04-18 17:13 PDT, EWS Watchlist	no flags	Details
Patch (4.03 KB, patch) 2018-04-18 19:37 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-sierra (2.27 MB, application/zip) 2018-04-18 20:41 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.75 MB, application/zip) 2018-04-18 20:45 PDT, EWS Watchlist	no flags	Details
Patch (8.90 KB, patch) 2018-04-18 20:49 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (13) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2018-03-31 00:27:20 PDT

Ignore the attachment I’ve uploaded. I’ll upload the right one in a moment.

mitz

Comment 2 2018-03-31 00:27:55 PDT

Created attachment 336921 [details] Test program

Radar WebKit Bug Importer

Comment 3 2018-04-03 10:32:48 PDT

<rdar://problem/39145306>

Chris Dumez

Comment 4 2018-04-18 09:50:17 PDT

This is a regression from https://trac.webkit.org/changeset/229133 where we stopped doing navigation policy checks for about:blank.

Chris Dumez

Comment 5 2018-04-18 10:40:28 PDT

Created attachment 338225 [details] Patch

EWS Watchlist

Comment 6 2018-04-18 11:50:08 PDT

Comment on attachment 338225 [details] Patch Attachment 338225 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7360075 New failing tests: webarchive/loading/javascript-url-iframe-crash.html

EWS Watchlist

Comment 7 2018-04-18 11:50:09 PDT

Created attachment 338235 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 8 2018-04-18 12:14:19 PDT

Comment on attachment 338225 [details] Patch Attachment 338225 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7360112 New failing tests: webarchive/loading/javascript-url-iframe-crash.html

EWS Watchlist

Comment 9 2018-04-18 12:14:21 PDT

Created attachment 338240 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Chris Dumez

Comment 10 2018-04-18 15:21:34 PDT

Created attachment 338268 [details] WIP patch

EWS Watchlist

Comment 11 2018-04-18 16:24:17 PDT

Comment on attachment 338268 [details] WIP patch Attachment 338268 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7363645 New failing tests: fast/loader/policy-delegate-action-hit-test-zoomed.html

EWS Watchlist

Comment 12 2018-04-18 16:24:19 PDT

Created attachment 338274 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 13 2018-04-18 16:28:44 PDT

Comment on attachment 338268 [details] WIP patch Attachment 338268 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7363657 New failing tests: fast/events/beforeunload-alert-user-interaction2.html http/tests/security/contentSecurityPolicy/plugin-blocked-in-about-blank-window.html webarchive/loading/javascript-url-iframe-crash.html fast/events/beforeunload-alert.html http/tests/security/contentSecurityPolicy/image-blocked-in-about-blank-window.html fast/loader/policy-delegate-action-hit-test-zoomed.html

EWS Watchlist

Comment 14 2018-04-18 16:28:47 PDT

Created attachment 338277 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 15 2018-04-18 16:57:01 PDT

Comment on attachment 338268 [details] WIP patch Attachment 338268 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7363710 New failing tests: fast/loader/policy-delegate-action-hit-test-zoomed.html

EWS Watchlist

Comment 16 2018-04-18 16:57:03 PDT

Created attachment 338280 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 17 2018-04-18 17:04:01 PDT

Comment on attachment 338268 [details] WIP patch Attachment 338268 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7364196 New failing tests: fast/events/beforeunload-alert-user-interaction2.html webarchive/loading/javascript-url-iframe-crash.html fast/events/beforeunload-alert.html fast/scrolling/scroll-to-focused-element-asynchronously.html http/tests/security/contentSecurityPolicy/image-blocked-in-about-blank-window.html

EWS Watchlist

Comment 18 2018-04-18 17:04:04 PDT

Created attachment 338283 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

EWS Watchlist

Comment 19 2018-04-18 17:12:51 PDT

Comment on attachment 338268 [details] WIP patch Attachment 338268 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7364166 New failing tests: fast/loader/policy-delegate-action-hit-test-zoomed.html

EWS Watchlist

Comment 20 2018-04-18 17:13:02 PDT

Created attachment 338284 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Chris Dumez

Comment 21 2018-04-18 19:37:12 PDT

Created attachment 338297 [details] Patch

EWS Watchlist

Comment 22 2018-04-18 20:41:22 PDT

Comment on attachment 338297 [details] Patch Attachment 338297 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7366296 New failing tests: fast/loader/policy-delegate-action-hit-test-zoomed.html

EWS Watchlist

Comment 23 2018-04-18 20:41:23 PDT

Created attachment 338301 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 24 2018-04-18 20:45:55 PDT

Comment on attachment 338297 [details] Patch Attachment 338297 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7366302 New failing tests: fast/loader/policy-delegate-action-hit-test-zoomed.html fast/loader/iframe-src-invalid-url.html loader/navigation-policy/should-open-external-urls/subframe-click-target-top.html loader/navigation-policy/should-open-external-urls/subframe-click-target-self.html

EWS Watchlist

Comment 25 2018-04-18 20:45:56 PDT

Created attachment 338302 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Chris Dumez

Comment 26 2018-04-18 20:49:52 PDT

Created attachment 338303 [details] Patch

WebKit Commit Bot

Comment 27 2018-04-19 13:57:58 PDT

Comment on attachment 338303 [details] Patch Clearing flags on attachment: 338303 Committed r230818: <https://trac.webkit.org/changeset/230818>

WebKit Commit Bot

Comment 28 2018-04-19 13:58:00 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P1

Severity Normal

Classification Unclassified

Version WebKit Local Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component WebKit API

Assignee

Chris Dumez

Reported

2018-03-31 00:24 PDT

Modified

2018-04-20 15:54 PDT History

CC List

9 users Show

URL

Keywords InRadar

Depends on

Blocks

183225 184848

Dependencies

tree graph