Bug 184720 - Improve the performance of FontCascadeDescription's effectiveFamilies
Summary: Improve the performance of FontCascadeDescription's effectiveFamilies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-17 17:27 PDT by Myles C. Maxfield
Modified: 2018-04-30 17:23 PDT (History)
5 users (show)

See Also:

Attachments
WIP (11.12 KB, patch)
2018-04-17 17:28 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
WIP (12.06 KB, patch)
2018-04-18 03:40 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (4.72 KB, patch)
2018-04-30 16:20 PDT, Myles C. Maxfield 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-04-17 17:27:50 PDT 
Improve the performance of FontCascadeDescription's effectiveFamilies
Comment 1 Myles C. Maxfield 2018-04-17 17:28:31 PDT 
Created attachment 338168 [details]
WIP
Comment 2 Myles C. Maxfield 2018-04-17 17:29:11 PDT 
<rdar://problem/38970927>
Comment 3 Myles C. Maxfield 2018-04-18 03:40:53 PDT 
Created attachment 338208 [details]
WIP
Comment 4 Myles C. Maxfield 2018-04-30 16:20:45 PDT 
Created attachment 339159 [details]
Patch
Comment 5 Simon Fraser (smfr) 2018-04-30 16:30:06 PDT 
Comment on attachment 339159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339159&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=184720

Radar number.

> Source/WebCore/ChangeLog:9
> +        with roughly few number of individual fonts. It turns out we were calling into the system-ui

"with roughly few number" ?

> Source/WebCore/ChangeLog:11
> +        https://bugs.webkit.org/show_bug.cgi?id=175845). These data URLS are never for the system font,

are never what?
Comment 6 Myles C. Maxfield 2018-04-30 17:23:30 PDT 
Committed r231187: <https://trac.webkit.org/changeset/231187>