Bug 175845 – Data URL fonts split in the middle of an alphabet cause random letters to disappear

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Data URL fonts split in the middle of an alphabet cause random letters to disappear

[Myles C. Maxfield]

Created attachment 318798 [details]
Patch

[Myles C. Maxfield]

Created attachment 318800 [details]
Patch

[Myles C. Maxfield]

Created attachment 318801 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/33996578>

[Build Bot]

Comment on attachment 318801 [details]
Patch

Attachment 318801 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4364218

New failing tests:
fast/text/font-load-data-partitioned-alphabet.html

[Build Bot]

Created attachment 318818 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 318801 [details]
Patch

Attachment 318801 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4364295

New failing tests:
fast/text/font-load-data-partitioned-alphabet.html

[Build Bot]

Created attachment 318823 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Jon Lee]

ping?

[Myles C. Maxfield]

Created attachment 329180 [details]
Patch

[Brent Fulgham]

Comment on attachment 329180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329180&action=review

Looks good, and the bots are happy. r=me

> Source/WebCore/css/CSSFontFaceSource.cpp:115
> +    if (status() == Status::Pending && m_font && m_font->url().protocolIsData() && m_familyNameOrURI.length() < 1024 * 1024)

Is 1024 * 1024 selected for a specific reason? Should this be encoded as a constant of some kind to explain its meaning?

> Source/WebCore/platform/graphics/FontCascadeFonts.cpp:397
> +        const auto& currentFamily = description.effectiveFamilyAt(i);

Could we be WTFMove-ing this currentFamily to the visit?

[Myles C. Maxfield]

Comment on attachment 329180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329180&action=review

>> Source/WebCore/css/CSSFontFaceSource.cpp:115
>> +    if (status() == Status::Pending && m_font && m_font->url().protocolIsData() && m_familyNameOrURI.length() < 1024 * 1024)
> 
> Is 1024 * 1024 selected for a specific reason? Should this be encoded as a constant of some kind to explain its meaning?

WTF::MB

>> Source/WebCore/platform/graphics/FontCascadeFonts.cpp:397
>> +        const auto& currentFamily = description.effectiveFamilyAt(i);
> 
> Could we be WTFMove-ing this currentFamily to the visit?

No reason to move because the visitor uses references.

[Myles C. Maxfield]

Created attachment 331248 [details]
Patch for committing

[WebKit Commit Bot]

Comment on attachment 331248 [details]
Patch for committing

Clearing flags on attachment: 331248

Committed r226930: <https://trac.webkit.org/changeset/226930>