WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
184691
Accept two values in the overflow shorthand
https://bugs.webkit.org/show_bug.cgi?id=184691
Summary
Accept two values in the overflow shorthand
Chris Nardi
Reported
2018-04-17 07:35:20 PDT
In
https://github.com/w3c/csswg-drafts/issues/2484
it was resolved to accept one or two values in the overflow shorthand, instead of only one. If two values are specified, the first would be used for overflow-x and the second for overflow-y. This has been implemented by Firefox, and (hopefully) soon to be Chrome. A test case for this can be found at
https://w3c-test.org/css/css-overflow/overflow-shorthand-001.html
.
Attachments
Patch
(29.25 KB, patch)
2019-10-07 16:01 PDT
,
Alexey Shvayka
no flags
Details
Formatted Diff
Diff
Patch
(33.68 KB, patch)
2019-10-08 07:08 PDT
,
Alexey Shvayka
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2018-04-20 18:03:35 PDT
<
rdar://problem/39615324
>
Alexey Shvayka
Comment 2
2019-10-07 16:01:45 PDT
Created
attachment 380371
[details]
Patch
Simon Fraser (smfr)
Comment 3
2019-10-07 16:36:17 PDT
Comment on
attachment 380371
[details]
Patch Thanks for the patch!
Simon Fraser (smfr)
Comment 4
2019-10-07 16:59:23 PDT
Comment on
attachment 380371
[details]
Patch There's a broken test.
Alexey Shvayka
Comment 5
2019-10-07 17:00:24 PDT
(In reply to Simon Fraser (smfr) from
comment #3
)
> Comment on
attachment 380371
[details]
> Patch > > Thanks for the patch!
Thanks for the review. I've withdrawn commit-queue because "web-platform-tests/css/cssom/shorthand-values.html" is failing. I would like to wait until "fast/css/invalidation-errors.html" passes on ios-wk2 to adjust expectations if needed.
Alexey Shvayka
Comment 6
2019-10-08 07:08:15 PDT
Created
attachment 380426
[details]
Patch Set reviewer and adjust tests expectations.
WebKit Commit Bot
Comment 7
2019-10-08 12:24:30 PDT
Comment on
attachment 380426
[details]
Patch Clearing flags on attachment: 380426 Committed
r250849
: <
https://trac.webkit.org/changeset/250849
>
WebKit Commit Bot
Comment 8
2019-10-08 12:24:32 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug