Bug 184691 - Accept two values in the overflow shorthand
Summary: Accept two values in the overflow shorthand
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: https://drafts.csswg.org/css-overflow...
Keywords: InRadar
Depends on: 202635
Blocks:
  Show dependency tree / graph
 
Reported: 2018-04-17 07:35 PDT by Chris Nardi
Modified: 2019-10-08 12:24 PDT (History)
12 users (show)

See Also:

Attachments
Patch (29.25 KB, patch)
2019-10-07 16:01 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Patch (33.68 KB, patch)
2019-10-08 07:08 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Nardi 2018-04-17 07:35:20 PDT 
In https://github.com/w3c/csswg-drafts/issues/2484 it was resolved to accept one or two values in the overflow shorthand, instead of only one. If two values are specified, the first would be used for overflow-x and the second for overflow-y. This has been implemented by Firefox, and (hopefully) soon to be Chrome.

A test case for this can be found at https://w3c-test.org/css/css-overflow/overflow-shorthand-001.html.
Comment 1 Radar WebKit Bug Importer 2018-04-20 18:03:35 PDT 
<rdar://problem/39615324>
Comment 2 Alexey Shvayka 2019-10-07 16:01:45 PDT 
Created attachment 380371 [details]
Patch
Comment 3 Simon Fraser (smfr) 2019-10-07 16:36:17 PDT 
Comment on attachment 380371 [details]
Patch

Thanks for the patch!
Comment 4 Simon Fraser (smfr) 2019-10-07 16:59:23 PDT 
Comment on attachment 380371 [details]
Patch

There's a broken test.
Comment 5 Alexey Shvayka 2019-10-07 17:00:24 PDT 
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 380371 [details]
> Patch
> 
> Thanks for the patch!

Thanks for the review.

I've withdrawn commit-queue because "web-platform-tests/css/cssom/shorthand-values.html" is failing. I would like to wait until "fast/css/invalidation-errors.html" passes on ios-wk2 to adjust expectations if needed.
Comment 6 Alexey Shvayka 2019-10-08 07:08:15 PDT 
Created attachment 380426 [details]
Patch

Set reviewer and adjust tests expectations.
Comment 7 WebKit Commit Bot 2019-10-08 12:24:30 PDT 
Comment on attachment 380426 [details]
Patch

Clearing flags on attachment: 380426

Committed r250849: <https://trac.webkit.org/changeset/250849>
Comment 8 WebKit Commit Bot 2019-10-08 12:24:32 PDT 
All reviewed patches have been landed.  Closing bug.