Bug 184631 - [Extra zoom mode] Double tap to zoom should account for text legibility in extra zoom mode
Summary: [Extra zoom mode] Double tap to zoom should account for text legibility in ex...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-14 16:45 PDT by Wenson Hsieh
Modified: 2018-04-20 11:33 PDT (History)
6 users (show)

See Also:


Attachments
Patch (13.44 KB, patch)
2018-04-14 17:14 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Try to fix OpenSource iOS builds (13.48 KB, patch)
2018-04-14 19:16 PDT, Wenson Hsieh
thorton: review+
Details | Formatted Diff | Diff
Patch for landing (13.18 KB, patch)
2018-04-17 19:11 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-04-14 16:45:50 PDT
Part 2 of <https://bugs.webkit.org/show_bug.cgi?id=184435>.
Comment 1 Wenson Hsieh 2018-04-14 16:46:22 PDT
<rdar://problem/39303706>
Comment 2 Wenson Hsieh 2018-04-14 17:14:30 PDT
Created attachment 337966 [details]
Patch
Comment 3 Wenson Hsieh 2018-04-14 19:16:49 PDT
Created attachment 337969 [details]
Try to fix OpenSource iOS builds
Comment 4 Tim Horton 2018-04-17 17:00:12 PDT
Comment on attachment 337969 [details]
Try to fix OpenSource iOS builds

Not sure about the logging. When is RELEASE_LOG on?
Comment 5 Wenson Hsieh 2018-04-17 17:08:23 PDT
(In reply to Tim Horton from comment #4)
> Comment on attachment 337969 [details]
> Try to fix OpenSource iOS builds
> 
> Not sure about the logging. When is RELEASE_LOG on?

It's on if we're building for macOS, or we're building for iOS with an internal SDK. Per IRC discussion, I'll downgrade these to debug logs.
Comment 6 Wenson Hsieh 2018-04-17 19:11:22 PDT
Created attachment 338182 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2018-04-17 19:50:31 PDT
Comment on attachment 338182 [details]
Patch for landing

Clearing flags on attachment: 338182

Committed r230746: <https://trac.webkit.org/changeset/230746>