Bug 184435 - [Extra zoom mode] Add a mechanism to zoom to fixed scales when double tapping in extra zoom mode
Summary: [Extra zoom mode] Add a mechanism to zoom to fixed scales when double tapping...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-09 19:09 PDT by Wenson Hsieh
Modified: 2018-04-11 09:00 PDT (History)
7 users (show)

See Also:

Attachments
Patch (25.60 KB, patch)
2018-04-09 20:46 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix WPE builds (25.52 KB, patch)
2018-04-09 20:51 PDT, Wenson Hsieh 		dino: review+
Details | Formatted Diff | Diff
Patch for landing (25.47 KB, patch)
2018-04-10 17:24 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-04-09 19:09:18 PDT 
<rdar://problem/38726260>
Comment 1 Wenson Hsieh 2018-04-09 20:46:10 PDT 
Created attachment 337581 [details]
Patch
Comment 2 Wenson Hsieh 2018-04-09 20:51:28 PDT 
Created attachment 337582 [details]
Fix WPE builds
Comment 3 Dean Jackson 2018-04-10 14:47:47 PDT 
Comment on attachment 337582 [details]
Fix WPE builds

View in context: https://bugs.webkit.org/attachment.cgi?id=337582&action=review

> Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.cpp:141
> +        return { };

Should this be nullopt?
Comment 4 Wenson Hsieh 2018-04-10 15:10:50 PDT 
Comment on attachment 337582 [details]
Fix WPE builds

View in context: https://bugs.webkit.org/attachment.cgi?id=337582&action=review

>> Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.cpp:141
>> +        return { };
> 
> Should this be nullopt?

Sure! Changed to std::nullopt.
Comment 5 Wenson Hsieh 2018-04-10 17:24:29 PDT 
Created attachment 337659 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-04-10 18:02:59 PDT 
Comment on attachment 337659 [details]
Patch for landing

Clearing flags on attachment: 337659

Committed r230506: <https://trac.webkit.org/changeset/230506>