Bug 184580 – [Web Animations] Fix animations/stop-animation-on-suspend.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

The test at animations/stop-animation-on-suspend.html fails reliably on iOS with the new animation engine.

[Radar WebKit Bug Importer]

<rdar://problem/39406014>

[Antoine Quint]

This isn't specific to iOS actually, it also fails on Mac but it was already marked as a flaky Failure for that platform so the error was not reported.

[Antoine Quint]

This test has always been problematic, see https://bugs.webkit.org/show_bug.cgi?id=49182.

[Antoine Quint]

I believe the expectations of this test to be incorrect. The test animates a transform from 0 to 400px across 400ms with a linear timing function. The test suspends animations from 100ms to 300ms with timers, and polls animations at 200ms and 400ms. At 200ms, it expects a value of 100px, which is correct since the animation is suspended and so the value at 100ms (when it was suspended) is expected.

However, the test expected the value at 400ms to be 200px, which leads me to think this test assumes that animations, when resumed, account for the time suspended and subtracts it from the page time. This is incorrect: when animations resume, they resume at the current time, no matter how long they were suspended. So the expected value should be 400px.

I will file a patch with this change in expectation.

[Antoine Quint]

Created attachment 390238 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 390238 [details]
Patch

Clearing flags on attachment: 390238

Committed r256177: <https://trac.webkit.org/changeset/256177>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.