Bug 18450 - SVG animation flickers when restarting
Summary: SVG animation flickers when restarting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://mcc.id.au/temp/2008/anim-flick...
Keywords:
Depends on:
Blocks: 41761
  Show dependency treegraph
 
Reported: 2008-04-12 19:08 PDT by Cameron McCormack (:heycam)
Modified: 2011-06-28 01:58 PDT (History)
5 users (show)

See Also:


Attachments
Patch for SVG animation flickers when restarting (7.47 KB, patch)
2011-06-14 06:49 PDT, Felician Marton
kling: review-
Details | Formatted Diff | Diff
Patch for SVG animation flickers when restarting (8.62 KB, patch)
2011-06-14 09:01 PDT, Felician Marton
krit: review-
krit: commit-queue-
Details | Formatted Diff | Diff
Patch for SVG animation flickers when restarting (8.72 KB, patch)
2011-06-27 02:39 PDT, Felician Marton
no flags Details | Formatted Diff | Diff
Patch for SVG animation flickers when restarting (8.71 KB, patch)
2011-06-28 00:10 PDT, Felician Marton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2008-04-12 19:08:48 PDT
When an animation restarts, it seems to briefly apply the end value before interpolating from the beginning again.

Load the URL above, click the rect, wait the 2 seconds for the animation to finish, then click the rect again.  Upon the second click, you can see that the rect briefly has width 100 before interpolating from 50 to 100.
Comment 1 Felician Marton 2011-05-30 06:12:18 PDT
I can confirm this, it also accours on qt-linux.
Comment 2 Felician Marton 2011-06-14 06:49:12 PDT
Created attachment 97110 [details]
Patch for SVG animation flickers when restarting
Comment 3 Andreas Kling 2011-06-14 06:50:57 PDT
Comment on attachment 97110 [details]
Patch for SVG animation flickers when restarting

View in context: https://bugs.webkit.org/attachment.cgi?id=97110&action=review

> Source/WebCore/ChangeLog:8
> +        This change eliminates the flickering when SVG animation restarting.

This is not a sufficient ChangeLog. Please explain what your patch is doing and why. :-)
Comment 4 Felician Marton 2011-06-14 09:01:09 PDT
Created attachment 97126 [details]
Patch for SVG animation flickers when restarting
Comment 5 Nikolas Zimmermann 2011-06-15 03:34:40 PDT
Dirk, do you think this patch is reasonable as-is?
Comment 6 Dirk Schulze 2011-06-18 22:58:05 PDT
Comment on attachment 97126 [details]
Patch for SVG animation flickers when restarting

Patch looks great! We need regression tests for changes like that. Sadly I don't know a way how to test. Maybe with SVGSVGElements getCurrentTime()? Can you check this? Anyway, even if there is no way to test it, this needs to be noted in the changelog. But please try to find  a way first.
Comment 7 Felician Marton 2011-06-27 02:39:45 PDT
Created attachment 98691 [details]
Patch for SVG animation flickers when restarting

I think there is no way to tests SVG flickering. I noted it in the ChangeLog.
Comment 8 Nikolas Zimmermann 2011-06-27 08:22:41 PDT
Comment on attachment 98691 [details]
Patch for SVG animation flickers when restarting

View in context: https://bugs.webkit.org/attachment.cgi?id=98691&action=review

Looks good to me, you forgot to ask for review, though - can you upload a new one that I can r+ and cq+ ?

> Source/WebCore/ChangeLog:18
> +        The following methods just modified for standardization:

s/standardization/consistency/.

> Source/WebCore/ChangeLog:22
> +         No new tests, because currently there is no way to test SVG flickering at zero time.

One space too much.
Comment 9 Felician Marton 2011-06-27 08:52:13 PDT
The latest patch is incorrect. Thats why I marked it to obsolate.
Comment 10 Felician Marton 2011-06-28 00:02:49 PDT
(In reply to comment #9)
> The latest patch is incorrect. Thats why I marked it to obsolate.

The patch is ok. There was some problem with my repo.
Comment 11 Felician Marton 2011-06-28 00:10:16 PDT
Created attachment 98869 [details]
Patch for SVG animation flickers when restarting

Only spelling and spacing fixed according to the prev patch.
Comment 12 Nikolas Zimmermann 2011-06-28 01:34:54 PDT
Comment on attachment 98869 [details]
Patch for SVG animation flickers when restarting

r=me!
Comment 13 WebKit Review Bot 2011-06-28 01:58:42 PDT
Comment on attachment 98869 [details]
Patch for SVG animation flickers when restarting

Clearing flags on attachment: 98869

Committed r89907: <http://trac.webkit.org/changeset/89907>
Comment 14 WebKit Review Bot 2011-06-28 01:58:47 PDT
All reviewed patches have been landed.  Closing bug.