Bug 184377 - [WPE] Use GNU install directories
Summary: [WPE] Use GNU install directories
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
: 178956 (view as bug list)
Depends on:
Blocks: 178894
  Show dependency treegraph
 
Reported: 2018-04-06 17:51 PDT by Michael Catanzaro
Modified: 2018-06-19 13:48 PDT (History)
4 users (show)

See Also:


Attachments
Patch (16.86 KB, patch)
2018-04-07 20:08 PDT, Michael Catanzaro
cgarcia: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-04-06 17:51:33 PDT
The secondary processes are being installed into bindir, which is inappropriate because they aren't intended to be executed by the user and should not be in PATH. They need to go in libexecdir.
Comment 1 Michael Catanzaro 2018-04-07 20:08:52 PDT
Created attachment 337438 [details]
Patch
Comment 2 Adrian Perez 2018-04-09 03:32:01 PDT
The changes introduced by the patch are indeed the correct thing
to do. I am in favor of landing this :-)
Comment 3 Michael Catanzaro 2018-04-09 06:28:28 PDT
I'll fix GTK before landing
Comment 4 Michael Catanzaro 2018-04-09 06:39:13 PDT
I'll enable WEBKIT_EXEC_PATH for WebKitGTK+ before landing as well, which was requested, unless somebody objects.
Comment 5 Carlos Garcia Campos 2018-04-09 07:06:37 PDT
Comment on attachment 337438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337438&action=review

> Source/WebKit/Shared/glib/ProcessExecutablePathGLib.cpp:44
> +    return String();

return { };
Comment 6 Michael Catanzaro 2018-04-09 07:29:55 PDT
(In reply to Michael Catanzaro from comment #4)
> I'll enable WEBKIT_EXEC_PATH for WebKitGTK+ before landing as well, which
> was requested, unless somebody objects.

Actually this isn't really needed.

(In reply to Carlos Garcia Campos from comment #5)
> Comment on attachment 337438 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=337438&action=review
> 
> > Source/WebKit/Shared/glib/ProcessExecutablePathGLib.cpp:44
> > +    return String();
> 
> return { };

OK.
Comment 7 Michael Catanzaro 2018-04-09 08:45:52 PDT
Committed r230429: <https://trac.webkit.org/changeset/230429>
Comment 8 Adrian Perez 2018-06-19 13:48:25 PDT
*** Bug 178956 has been marked as a duplicate of this bug. ***