Bug 184377 – [WPE] Use GNU install directories

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Michael Catanzaro]

The secondary processes are being installed into bindir, which is inappropriate because they aren't intended to be executed by the user and should not be in PATH. They need to go in libexecdir.

[Michael Catanzaro]

Created attachment 337438 [details]
Patch

[Adrian Perez]

The changes introduced by the patch are indeed the correct thing
to do. I am in favor of landing this :-)

[Michael Catanzaro]

I'll fix GTK before landing

[Michael Catanzaro]

I'll enable WEBKIT_EXEC_PATH for WebKitGTK+ before landing as well, which was requested, unless somebody objects.

[Carlos Garcia Campos]

Comment on attachment 337438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=337438&action=review

> Source/WebKit/Shared/glib/ProcessExecutablePathGLib.cpp:44
> +    return String();

return { };

[Michael Catanzaro]

(In reply to Michael Catanzaro from comment #4)
> I'll enable WEBKIT_EXEC_PATH for WebKitGTK+ before landing as well, which
> was requested, unless somebody objects.

Actually this isn't really needed.

(In reply to Carlos Garcia Campos from comment #5)
> Comment on attachment 337438 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=337438&action=review
> 
> > Source/WebKit/Shared/glib/ProcessExecutablePathGLib.cpp:44
> > +    return String();
> 
> return { };

OK.

[Michael Catanzaro]

Committed r230429: <https://trac.webkit.org/changeset/230429>

[Adrian Perez]

*** Bug 178956 has been marked as a duplicate of this bug. ***