WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
184337
WebContent process is calling CGDisplayUsesInvertedPolarity
https://bugs.webkit.org/show_bug.cgi?id=184337
Summary
WebContent process is calling CGDisplayUsesInvertedPolarity
Brent Fulgham
Reported
2018-04-05 12:22:42 PDT
We need to broker access to CGDisplayUsesInvertedPolarity so that the WebContent process doesn't need to use it. We already pass other screen-related values as part of ScreenProperties. We just need to add 'inverted color' status to this as well to avoid interacting with the NSDisplay in the WebContent process.
Attachments
Patch
(17.46 KB, patch)
2018-04-05 16:38 PDT
,
Brent Fulgham
no flags
Details
Formatted Diff
Diff
Patch
(17.63 KB, patch)
2018-04-05 17:03 PDT
,
Brent Fulgham
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2
(2.72 MB, application/zip)
2018-04-05 18:14 PDT
,
EWS Watchlist
no flags
Details
Patch
(17.59 KB, patch)
2018-04-05 19:50 PDT
,
Brent Fulgham
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2
(3.02 MB, application/zip)
2018-04-05 20:53 PDT
,
EWS Watchlist
no flags
Details
Patch for landing
(17.59 KB, patch)
2018-04-05 20:58 PDT
,
Brent Fulgham
bfulgham
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(5)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2018-04-05 12:23:19 PDT
<
rdar://problem/39215702
>
Brent Fulgham
Comment 2
2018-04-05 16:30:30 PDT
This is also happening for CGDisplayUsesForceToGray.
Brent Fulgham
Comment 3
2018-04-05 16:38:39 PDT
Created
attachment 337309
[details]
Patch
Brent Fulgham
Comment 4
2018-04-05 17:03:41 PDT
Created
attachment 337314
[details]
Patch
EWS Watchlist
Comment 5
2018-04-05 18:14:11 PDT
Comment on
attachment 337314
[details]
Patch
Attachment 337314
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/7220796
Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 6
2018-04-05 18:14:12 PDT
Created
attachment 337320
[details]
Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Brent Fulgham
Comment 7
2018-04-05 19:50:47 PDT
Created
attachment 337331
[details]
Patch
EWS Watchlist
Comment 8
2018-04-05 20:53:03 PDT
Comment on
attachment 337331
[details]
Patch
Attachment 337331
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/7222220
Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 9
2018-04-05 20:53:04 PDT
Created
attachment 337339
[details]
Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Brent Fulgham
Comment 10
2018-04-05 20:58:28 PDT
Created
attachment 337340
[details]
Patch for landing
Brent Fulgham
Comment 11
2018-04-05 21:44:35 PDT
Committed
r230323
: <
https://trac.webkit.org/changeset/230323
>
Brent Fulgham
Comment 12
2018-04-06 09:09:01 PDT
Follow-up fix landed in
r230331
: <
https://trac.webkit.org/changeset/230331/webkit
>
Brent Fulgham
Comment 13
2018-04-06 12:45:00 PDT
Another follow-up landed in
r230352
: <
https://trac.webkit.org/changeset/230352/webkit
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug