Bug 185515 - REGRESSION(r230323): UIProcess needs to notify WebContent process of Accessibility setting changes
Summary: REGRESSION(r230323): UIProcess needs to notify WebContent process of Accessib...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 184337
Blocks:
  Show dependency tree / graph
 
Reported: 2018-05-10 10:09 PDT by Brent Fulgham
Modified: 2018-05-10 11:32 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.39 KB, patch)
2018-05-10 10:24 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch for landing (5.39 KB, patch)
2018-05-10 10:54 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-05-10 10:09:10 PDT 
In Bug 184337 I started caching the state of CGDisplayUsesInvertedPolarity (and other accessibility settings) so that we could message them from the UIProcess, and avoid interacting with the Window Server in the WebContent process.

Unfortunately, this caused certain accessibility features (such as inverted colors) to only be read when the UIProcess launched, because WebKit was not registered to be notified when screen-affecting accessibility changes were made.

Instead, WebKit needs to register to be notified if accessibility preferences change so that it can notify the related WebContent processes that their screen characteristics may have changed.
Comment 1 Brent Fulgham 2018-05-10 10:09:49 PDT 
<rdar://problem/39627764>
Comment 2 Brent Fulgham 2018-05-10 10:24:19 PDT 
Created attachment 340099 [details]
Patch
Comment 3 Brent Fulgham 2018-05-10 10:54:27 PDT 
Created attachment 340104 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2018-05-10 11:32:05 PDT 
Comment on attachment 340104 [details]
Patch for landing

Clearing flags on attachment: 340104

Committed r231648: <https://trac.webkit.org/changeset/231648>
Comment 5 WebKit Commit Bot 2018-05-10 11:32:06 PDT 
All reviewed patches have been landed.  Closing bug.